Review main Merged

70060[BUGFIX] Skip range validation if input value and default are both "0"

Nikita Hovratov CR +2 V +2 Normal +95 −26 updated 07/29/21, 15:26

Commit message

This patch fixes a regression originally introduced in #94103. The
problem there was simply an erroneous strict comparison, which further
got completely removed in #94527 due to a misconception.

The mentioned condition is important for date type fields with a lower
range set in TCA. If the user doesn't provide a value for that date
field, the range validation should be skipped. Otherwise this empty
value would always be interpreted as 0, resulting the validation to
change it to the lower range value.

As this is a special case, the condition was extracted and rewritten,
to only apply for this exact scenario. Other than that the validation
should not be skipped.

An acceptance test and a unit test are added to ensure this behavior
can't break anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1928

Show 23 earlier messages
  1. Nikita Hovratov uploaded patch set 1 07/23/21, 14:38

  2. Nikita Hovratov commented on patch set 1 07/23/21, 14:41

    Unresolved

    Acceptance tests will be green, when next styleguide release will be included.
  3. core-ci voted on patch set 1 V -1 07/23/21, 14:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13693

  1. Nikita Hovratov uploaded patch set 2 07/23/21, 15:26

  2. core-ci voted on patch set 2 V -1 07/23/21, 15:40 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13695

  3. Nikita Hovratov uploaded patch set 3 07/24/21, 11:09

  4. core-ci voted on patch set 3 V -1 07/24/21, 11:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13709

  5. Oliver Klee commented on patch set 3 07/25/21, 07:41

    Love it that you have added regression tests with the fix!
  6. Marcus Schwemer voted on patch set 3 V +1 CR +1 07/26/21, 06:45

  7. core-ci commented on patch set 3 07/26/21, 09:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13709

  8. Oliver Klee wrote 07/26/21, 11:19

    Removed reviewer Oliver Klee.
  9. Nikita Hovratov uploaded patch set 4 07/26/21, 13:09

  10. Nikita Hovratov commented on patch set 4 07/26/21, 13:10

    Only some comment / php doc changes. AC tests still require styleguide update: https://github.com/TYPO3/styleguide/pull/228
  11. core-ci voted on patch set 4 V -1 07/26/21, 13:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13760

  12. Christian Kuhn uploaded patch set 5 07/28/21, 13:35

  13. Christian Kuhn commented on patch set 5 CR -1 07/28/21, 13:35

    temp commit: verify if green with styleguide dev-master.
  14. core-ci voted on patch set 5 V -1 07/28/21, 13:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13845

  15. Christian Kuhn uploaded patch set 6 07/28/21, 13:59

  16. Christian Kuhn voted on patch set 6 CR -1 07/28/21, 14:00

  17. core-ci voted on patch set 6 V +1 07/28/21, 14:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13846

  18. Christian Kuhn uploaded patch set 7 07/28/21, 15:57

  19. core-ci voted on patch set 7 V +1 07/28/21, 16:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13850

  20. Christian Kuhn voted on patch set 7 CR -1 07/28/21, 16:15

  21. Christian Kuhn uploaded patch set 8 07/28/21, 17:24

  22. core-ci voted on patch set 8 V +1 07/28/21, 17:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13854

  23. Christian Kuhn voted on patch set 8 V +1 CR +1 07/29/21, 08:36

  24. Benni Mack voted on patch set 8 V +2 CR +2 07/29/21, 15:26

  25. Benni Mack merged patch set 9 07/29/21, 15:26