70060[BUGFIX] Skip range validation if input value and default are both "0"
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 3
Review log 1928
Show 23 earlier messages
-
Nikita Hovratov uploaded patch set 1 07/23/21, 14:38
-
Nikita Hovratov commented on patch set 1 07/23/21, 14:41
-
core-ci voted on patch set 1 V -1 07/23/21, 14:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13693
-
Nikita Hovratov uploaded patch set 2 07/23/21, 15:26
-
core-ci voted on patch set 2 V -1 07/23/21, 15:40 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13695
-
Nikita Hovratov uploaded patch set 3 07/24/21, 11:09
-
core-ci voted on patch set 3 V -1 07/24/21, 11:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13709
-
Oliver Klee commented on patch set 3 07/25/21, 07:41
Love it that you have added regression tests with the fix! -
Marcus Schwemer voted on patch set 3 V +1 CR +1 07/26/21, 06:45
-
core-ci commented on patch set 3 07/26/21, 09:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13709
-
Oliver Klee wrote 07/26/21, 11:19
Removed reviewer Oliver Klee. -
Nikita Hovratov uploaded patch set 4 07/26/21, 13:09
-
Nikita Hovratov commented on patch set 4 07/26/21, 13:10
Only some comment / php doc changes. AC tests still require styleguide update: https://github.com/TYPO3/styleguide/pull/228 -
core-ci voted on patch set 4 V -1 07/26/21, 13:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13760
-
Christian Kuhn uploaded patch set 5 07/28/21, 13:35
-
Christian Kuhn commented on patch set 5 CR -1 07/28/21, 13:35
temp commit: verify if green with styleguide dev-master. -
core-ci voted on patch set 5 V -1 07/28/21, 13:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13845
-
Christian Kuhn uploaded patch set 6 07/28/21, 13:59
-
Christian Kuhn voted on patch set 6 CR -1 07/28/21, 14:00
-
core-ci voted on patch set 6 V +1 07/28/21, 14:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13846
-
Christian Kuhn uploaded patch set 7 07/28/21, 15:57
-
core-ci voted on patch set 7 V +1 07/28/21, 16:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13850
-
Christian Kuhn voted on patch set 7 CR -1 07/28/21, 16:15
-
Christian Kuhn uploaded patch set 8 07/28/21, 17:24
-
core-ci voted on patch set 8 V +1 07/28/21, 17:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13854
-
Christian Kuhn voted on patch set 8 V +1 CR +1 07/29/21, 08:36
-
Benni Mack voted on patch set 8 V +2 CR +2 07/29/21, 15:26
-
Benni Mack merged patch set 9 07/29/21, 15:26
Unresolved