Review main Abandoned

70062[TASK] Simplify & optimize readability of the page module interface

Rachel Foucard CR 0 V 0 Hard +233 −137 updated 11/11/21, 14:00

Commit message

The patch simplifies and optimizes the readability of the page
module interface (column and language submodules), without adding,
removing or changing the behavior of already existing features.

The colPos areas are visually simplified (background) and
don't propose additional edit buttons anymore.
The "Unused elements" has now a global warning background and
the warning style has been removed from the content items
so that they don't stay orange after a drag and drop in a real colpos
A new btn-fab (floating action buttons) style is applied to the "add new
content" and "paste" buttons.
The drop zones are streamlined with the positions and style of the "add
new content" buttons.
When a content element is dragged the "add new content button" below
isn't shown anymore.
The content element boxes and their header buttons are visually
simplified.
The language flag and title are removed from the content header and
the unecessary js relative to this html is removed as well. Instead,
when a content has the language -1 (All), this information is now
displayed in the content footer.
The content elements CType title is always shown beside the CType icon.
A new button for the content element context menu is added in the
content element header right button bar, in place of the delete button.
The content elements delete button is now inside the context menu
only.
The hidden content elements are now differenciated with a better opacity
and a dotted border.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 15

Review log 110159

Show 96134 earlier messages
  1. Rachel Foucard uploaded patch set 1 07/24/21, 08:40

  2. core-ci voted on patch set 1 V -1 07/24/21, 08:54 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13705

  3. Oliver Hader wrote 07/24/21, 09:00

    Topic set to sci
  4. Jonas Eberle uploaded patch set 2 07/24/21, 09:44

  5. Jonas Eberle uploaded patch set 3 07/24/21, 09:49

  6. core-ci voted on patch set 2 V -1 07/24/21, 09:59 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13707

  7. core-ci voted on patch set 3 V +1 07/24/21, 10:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13708

  8. Jonas Eberle voted on patch set 3 CR +1 07/24/21, 10:02

  9. Jonas Eberle updated the commit message in patch set 4 07/25/21, 08:53

  10. Jonas Eberle voted on patch set 4 V +1 CR +1 07/25/21, 08:54

  11. Anja Leichsenring updated the commit message in patch set 5 07/25/21, 09:01

  12. core-ci voted on patch set 4 V +1 07/25/21, 09:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13730

  13. core-ci voted on patch set 5 V +1 07/25/21, 09:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13731

  14. Jonas Eberle voted on patch set 5 V +1 CR +1 07/25/21, 10:49

  15. Oli Bartsch commented on patch set 5 07/26/21, 09:47

    locallang_layout.xlf:160

    Please note, unused is not the same as unassigned. This is a bug in the current fluid based page module implementation.
  16. Rachel Foucard commented on patch set 5 07/26/21, 14:49

    locallang_layout.xlf:160 Reply

    We can keep the original "unassigned" label if you think it's more clear? Also, after some trials, I see that the fluid template"/typo3/sysext/backend/Resources/PrivatePartials/PageLayout/Grid/ColumnHeader.html" has a strange bug: The handling of the colpos title is based on 3 cases: - if {column.active} which seems to be the case of a normal editable column, - else if {column.unassigned} which seems to be the case of a column containing unassigned contents because the rendered title is "Not assigned", - and else the remaining case, which seems to be the case of a non-editable column because the rendered title is "non-edit access". But the rendering of the "add new content button" is not handled in the same conditions and is always rendered: Then we have now the case of a column with the title "no edit access", but still a button to add content. The only way I have found to disable the "new content button" is to name the column "unused" in the backend layout configuration ( because : /typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumn.php function isContentEditable). We could simply move the "new content button" rendering in the first case {column.active}, but I don't know if it's the best way to solve the bug?
  17. Rachel Foucard commented on patch set 5 07/26/21, 16:42

    locallang_layout.xlf:160 Reply

  18. Jonas Eberle uploaded patch set 6 07/27/21, 06:57

  19. Jonas Eberle commented on patch set 6 07/27/21, 06:59

    locallang_layout.xlf:160 Reply

    Yes. Nice coincidence :) I'll rebase and remove the .xlf change so we can test with that patch.
  20. Jonas Eberle uploaded patch set 7 07/27/21, 07:00

  21. Jonas Eberle uploaded patch set 8 07/27/21, 07:00

  22. core-ci voted on patch set 6 V +1 07/27/21, 07:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13790

  23. core-ci commented on patch set 7 07/27/21, 07:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13791

  24. core-ci voted on patch set 8 V +1 07/27/21, 07:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13792

  25. Jonas Eberle voted on patch set 8 V +1 CR +1 07/28/21, 17:19

  26. Andreas Steiger commented on patch set 8 08/04/21, 07:22

    Nice Patch! Thanks Rachel. But why are there round buttons? The look and feel is so different to the other modules... And I don`t think, that the little circle drop area is nicer than the old wide rectangle section
  27. Andreas Steiger commented on patch set 8 V -1 08/04/21, 08:50

    I think this patch and the design of the page module here is not finished yet... It still looks 'cheap' and needs more love of details.
  28. Rachel Foucard uploaded patch set 9 08/04/21, 10:00

  29. Jonas Eberle voted on patch set 9 V +1 CR +1 08/04/21, 10:02

  30. core-ci voted on patch set 9 V +1 08/04/21, 10:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14078

  31. Andreas Steiger commented on patch set 9 V -1 CR -1 08/04/21, 10:44

    I think this patch and the design of the page module here is not finished yet... It still looks 'cheap' and needs more love of details. And I added some code comments

    _buttons.scss:45

    Why not 50%?

    _page.scss:233

    Is there no variable for this color?

    _page.scss:237

    "-0" ?? :) just "0" would be better

    _page.scss:334

    Is an !important really required? Without !important would be nicer
  32. Rachel Foucard commented on patch set 9 08/04/21, 11:05

    Reply

    Hello Andreas! Thanks for all the questions, I will try to answer in detail. There are also other questions that were asked this morning via slack, so I will put all the answers here: What brought all these changes? this is the result of many UX workshops of the Structured content initiative (all patches that will be proposed by this initiative will be tagged "sci"). We had posted some screenshots a long time ago: https://typo3.org/article/structured-content-initiative-what-happened-between-july-and-november. These screenshots were not final at the time, and we modified our initial ideas in order to answer accessibility issues and consistency with touch screen users. Where do these round buttons come from? they are floatting action buttons and here is a short definition: "A floating action button (FAB) performs the primary, or most common, action on a screen. It appears in front of all screen content, typically as a circular shape with an icon in its center." We determined that the main action in this module was to add content and wanted to use this design for them to get freedom in positioning them in the backend layout grids but keeping the layout structure easy to understand. The space has become important between the contents, would it be possible to reduce it as in the screenshot of the article by positioning them above the contents? Yes it is totally possible, since it's FAB buttons, we can improve that. The context menu isn't dark like the new context menu in the list module, could it be consistent with this new styling? Sure, first I thought it was a merge conflit issue, but it seems that the dark mode for the context menu is only in the list module for now. We could use the same styling for the other context menus (page tree, page module, etc.) modifing the context css in _element_contextmenu.scss, but it's a little bit out of our scope, should we? I don`t think, that the little circle drop area is nicer than the old wide rectangle section this change corresponds to the screenshots described above. The difference is that we preferred to keep the style of the old drop zones in order not to change too much the visual habits of the current editors, also because these dotted borders correspond well to drop zones in general. The orange and green are as before, and we added a scale effect to indicate that the drop is possible (as before), but it would be nice to add an additional icon to make the information clearer. I think this patch and the design of the page module here is not finished yet... It still looks 'cheap' and needs more love of details. Fair enough, for example the icon of the add content button seems blurred because we have a small problem of half-pixel. we will also correct that. thank you for taking the time for reviewing this patch! I will take care of the separated comments too.
  33. Rachel Foucard commented on patch set 9 08/04/21, 11:07

    _buttons.scss:45 Reply

    It's possible to have floatting action buttons with an icon + a label, in that case, with 50% we get a strange oval.
  34. Andreas Steiger commented on patch set 9 08/04/21, 11:25

    _buttons.scss:45 Reply

    Thanks. It is fine
  35. Rachel Foucard uploaded patch set 10 08/04/21, 13:39

  36. Rachel Foucard uploaded patch set 11 08/04/21, 13:41

  37. Rachel Foucard commented on patch set 11 08/04/21, 13:46

    Reply

    The new content buttons are now hovering the contents and the space is better used. The new content button doesn't seem blurred anymore. I didn't work on the dark context menu since I would prefer to do it in another patch related to all the context menus if it's ok to streamline all of them in a dark mode?

    _page.scss:233 Reply

    done

    _page.scss:237 Reply

    done

    _page.scss:334 Reply

    I didn't manage to make it work without !important (I really tried I promise!) but the content hovering seems to need it anyway
  38. core-ci voted on patch set 10 V -1 08/04/21, 14:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14092

  39. core-ci voted on patch set 11 V +1 08/04/21, 14:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14093

  40. Andreas Steiger commented on patch set 11 08/04/21, 19:50

    Thanks Rachel, it is better now. But IMHO is this not really ready to publish... Your patch is shurely good in UX and better for accessibility, but in the design view, it seems not worthy enough for TYPO3. We need more love, details and modern touch. Do you have blueprints, Designs, Screenshot for that? Why do you not follow the designs of your post https://typo3.org/article/structured-content-initiative-what-happened-between-july-and-november ?
  41. Rachel Foucard commented on patch set 11 08/05/21, 10:12

    Reply

    Hi Andreas, we have indeed a lot of screenshots and mockups they are reachable directly here: https://drive.google.com/drive/folders/1gr0fV8NwDp9ABqS8lfC5P_X0iikdHQyA?usp=sharing but the design from the original article is the most complete view of what we wanted to achieve. But it has some accessibility and UX issues. Thats the reason why there are differences today. If I look at the differences: The red left menu colpos isn't from our initiative, another patch seems to have changed the background recently, so we won't remove something that has just been merged. We first need to know why and who did that. In the article, the add button were supposed to appear only on hovering the contents, but some users won't understand, and there is no hovering on touch screens. The dropped zones didn't look enough as drop zones, it was a mixt between buttons and drop zone, it wasn't clear enought. The buttons are not colored now because in pages with a lot of contents that color would be too distractive and wouldn't help to recognize the page structure and reach easily a content. Maybe we could discuss that during a call to find the best way to achieve well the design without accessibility regression? Cheers, Rachel
  42. Rachel Foucard uploaded patch set 12 08/05/21, 10:14

  43. core-ci voted on patch set 12 V -1 08/05/21, 10:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14130

  44. Rachel Foucard uploaded patch set 13 08/17/21, 13:47

  45. Rachel Foucard commented on patch set 13 08/17/21, 13:55

    Hi! After some discussions last week with Andi, and then some validation with the members of the initiative, we were able to find a better design approach: the idea is to make the different modules design consistent. The Dashboard interface should be the model to follow. The floatting action buttons take the same design as in the dashboard, the content blocks too. The page module now seems much more in line with the TYPO3 design. Accessibility has not been put aside for the sake of design. Rachel
  46. core-ci voted on patch set 13 V -1 08/17/21, 14:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15236

  47. Rachel Foucard uploaded patch set 14 08/18/21, 15:01

  48. Rachel Foucard commented on patch set 14 08/18/21, 15:05

    Hello folks, We added some new design improvements and much more love 😊 the patch is now ready to be reviewed!
  49. Jonas Eberle uploaded patch set 15 08/18/21, 15:17

  50. core-ci voted on patch set 14 V +1 08/18/21, 15:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15272

  51. core-ci voted on patch set 15 V +1 08/18/21, 15:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15273

  52. Andreas Steiger commented on patch set 15 V +1 CR +1 08/18/21, 16:16

    Amazing Patch! Now it is so much better and works like a charm for me 😊 I love it. Great job Rachel!
  53. Jonas Eberle commented on patch set 15 V +1 CR +1 08/18/21, 16:39

    Reply

    Done

    Reply

    Done
  54. André Kraus voted on patch set 15 V +1 CR +1 08/18/21, 17:55

  55. Lidia Demin uploaded patch set 16 08/18/21, 18:07

  56. André Kraus voted on patch set 16 V +1 CR +1 08/18/21, 18:09

  57. Jonas Eberle voted on patch set 16 V +1 CR +1 08/18/21, 18:09

  58. Lidia Demin commented on patch set 16 V +1 08/18/21, 18:14

    I only added a small change and made the line between the content element's meta information and its content area for the hidden state. There are 2 things, I would like to change (open for discussion, could be done in another patch): 1. The "add content element" buttons look too heavy and distract from the content. Maybe a white background with a grey outline would be better? 2. For some editors it might be difficult to hit the drop zone, especially if they are used to a wider drop zone like it was before. Apart of that: great work!
  59. Lidia Demin voted on patch set 16 CR +1 08/18/21, 18:19

  60. core-ci voted on patch set 16 V +1 08/18/21, 18:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15281

  61. Andreas Steiger voted on patch set 16 V +1 CR +1 08/18/21, 19:31

  62. Oli Bartsch commented on patch set 16 CR -1 08/18/21, 21:00

    Hi, I really appreciate your work in the page module. Therefore, I hope we can improve the patch, taking all possible cases / variants (especially defLangBinding) into account. Also receiving some more feedback from people, not part of the initiative, would be great. In my short review, besides the topics mentioned in the files directly, I noticed the following: - There a some issues with defLangBinding (e.g. background and elements' header is cut off) - In Languages Mode, having default and a localization in connected mode => The elements in the localization grid do not have space between each other. Also the type icon as well as the type label break into a new line, with a lot of space to the action buttons in the top right corner - Having multiple localizations, the "new" button might overlay the action buttons - The "new" button is slightly bigger than the "paste" button - The action buttons still contain the "default" hover and focus styles
    I can not find such change in the the latest patchset.
    This has changed in the latest patchset, right?

    _page.scss:207

    What is the reason for hiding the language titles? A user does no longer recognize "-1" elements in the module. Also I don't think we should keep any not shown markup. Somewhere in the future someone will remove this as "it's not shown anymore". If needed for JavaScript, this should be supplied e.g. via data attributes or a custom element.

    _page.scss:216

    This is required due to the "hidden" language title, right?

    _page.scss:237

    Footer is the only section whose background is not white and also has no border. Is this intended?

    _page.scss:334

    .t3-page-ce-footer missing here? It now looks the same in both, active and inactive state.

    GridColumnItem.php:253

    If this getter is no longer used, we might remove it, especially because the class is internal.

    ColumnHeader.html:4

    This removes the possibility to edit multiple / all elements at once in the module. What is the reason for removing this useful feature?

    ColumnHeader.html:18

    Is there a reason why this class is not prefixed?

    Header.html:8

    What's the reason for removing the btn-group and defining the size for each button manually?

    Header.html:16

    Despite my question regarding the removal of the delete button and the duplicate definition of the context menu, links without a target are actually buttons.

    Header.html:17

    I use the delete button quite often. Actually more often than the edit or hide/unhide buttons. What is the reason for removing this quite important action? - In case we really remove this, we should also remove the left over methods (getDeleteUrl(), isDelible(), ...) Regarding the context menu. This is already available on the elements type icon. If at all, to be consistent, the "actions-menu-alternative" icon should open a secondary menu (bootstrap dropdown), like done in recordlist and filelist.
  63. Andreas Steiger commented on patch set 16 08/19/21, 07:12

    Reply

    I'm not part of the initiative. ;) Great review, dude!
  64. Jonas Eberle commented on patch set 16 08/19/21, 12:15

    Thank you for that in-depth review, Oliver!
  65. Rachel Foucard uploaded patch set 17 08/19/21, 16:44

  66. core-ci voted on patch set 17 V +1 08/19/21, 16:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15310

  67. Rachel Foucard commented on patch set 17 08/19/21, 17:20

    Reply

    Hi Oliver, thank you very much for your review, it really helps! concerning "There a some issues with defLangBinding (e.g. background and elements' header is cut off)" I didn't understand the problem, could you be more specific? concerning "In Languages Mode, having default and a localization in connected mode => The elements in the localization grid do not have space between each other. Also the type icon as well as the type label break into a new line, with a lot of space to the action buttons in the top right corner" Done concerning "Having multiple localizations, the "new" button might overlay the action buttons" Done concerning "The "new" button is slightly bigger than the "paste" button" Done concerning "The action buttons still contain the "default" hover and focus styles" Yes, it's in purpose, for UX and accessibility reasons hover and focus states are highlighted

    Reply

    you're right, and having a deeper look at the unused zone, I've done other improvements detailed now in the commit message

    Reply

    yes, finally we stay inline with the other modules like Dashboard and then decided to stay like before. I've just removed the text

    _page.scss:207 Reply

    The reason for hiding language information is that it's not usefull at all in the content item context (column or language mode). BUT you are right, the "all" language is important to show, and only in this case. So I would propose to add this information only when it's a "-1" language, and in the footer. I totally agree with not keeping this html if it's only needed for javascript handling, help would be much appreciate to remove in a cleaner way those information without breaking other features.

    _page.scss:216 Reply

    yes, so if we remove the html, we can remove this margin

    _page.scss:237 Reply

    yes, it help recognizing the footer without adding other borders and keeping a light design.

    _page.scss:334 Reply

    yes, the active and inactive states are globaly different with the content dashed border

    GridColumnItem.php:253 Reply

    I'm not the author of this comment so I can't confirm if it's really not used anymore, maybe Jonas can confirm that?

    ColumnHeader.html:4 Reply

    because this additional way to edit multiple contents isn't so usefull in a page module context. Edit multiple contents is more often done via the list module (mass actions) and in a much better way. The less action buttons we visually have in the page module, the better the UX is.

    ColumnHeader.html:18 Reply

    it's a bootstrap class

    Header.html:8 Reply

    for two reasons : first because it add space between buttons and improve usability also because grouping buttons in this case doesn't add any usefull meaning since the buttons are all in the same group

    Header.html:16 Reply

    I don't understand what you mean, should we change the link into a button instead?

    Header.html:17 Reply

    The delete action isn't "removed" but just moved in the overflow contextual menu. Why we did that: Delete action is always considered as: - a secondary action (maybe because we have first to create and edit before delete, and then, mathematically it's less often used than the other actions) - a "destructive" action (editors don't like that, they often prefer to hide instead of deleting data forever) putting a destructive action button on each and every content just next other editing action button is just a bad idea in terms of UX. here is a link to an additional explanation: https://www.nngroup.com/articles/top-10-application-design-mistakes/ (the 10th "Proximity of Destructive and Confirmation Actions")
  68. Rachel Foucard commented on patch set 17 08/19/21, 17:42

    Header.html:17 Reply

    Regarding the context menu, the new users don't guess that the icon is a menu, but the actual users will need time to change their habits so we keep both and maybe will remove the menu on the icon in a next version. We would like to streamline the design with the same dark mode of the recordlist menu but it should be also done for the contextual menu of the page tree, maybe it's for another patch?
  69. Jonas Eberle commented on patch set 17 08/19/21, 17:50

    Reply

    defLangBinding is a flag that makes sure CE translated variants are shown exactly next to each other in the language-side-by-side view. You can enable it via page settings -> Rescources -> PageTS: mod.web_layout.defLangBinding = 1 Watch out for some existing problems: https://forge.typo3.org/projects/typo3cms-core/search?utf8=%E2%9C%93&q=defLangBinding&scope=&all_words=&all_words=1&titles_only=&issues=1&open_issues=1&attachments=0&options=1&commit=Search

    GridColumnItem.php:253 Reply

    I didn't want deprecation discussions to interfere with the general patch review. If Oliver backs it up I am happy to have the whole function removed.
  70. Rachel Foucard uploaded patch set 18 08/19/21, 18:38

  71. core-ci voted on patch set 18 V +1 08/19/21, 18:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15312

  72. Rachel Foucard uploaded patch set 19 08/20/21, 18:25

  73. Rachel Foucard commented on patch set 19 08/20/21, 18:28

    Reply

    thank you Jonas, I've corrected the visual issues related to this patch.

    _page.scss:207 Reply

    Hi, the -1 case is now displayed in the footer.
  74. core-ci voted on patch set 19 V -1 08/20/21, 18:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15342

  75. Rachel Foucard uploaded patch set 20 08/22/21, 15:36

  76. Rachel Foucard commented on patch set 20 08/22/21, 15:39

    _page.scss:207 Reply

    Hi, the flag and language title html and the unecessary js relative to it have been removed.
  77. core-ci voted on patch set 20 V -1 08/22/21, 15:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15393

  78. Rachel Foucard uploaded patch set 21 08/22/21, 15:49

  79. core-ci voted on patch set 21 V -1 08/22/21, 15:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15394

  80. Rachel Foucard uploaded patch set 22 08/22/21, 15:56

  81. core-ci voted on patch set 22 V -1 08/22/21, 16:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15395

  82. Rachel Foucard commented on patch set 22 08/22/21, 16:02

    Reply

    Hi Liddy, the dropzone has been improved: the active state (orange) is bigger and the sensible zone and droppable state (green) is now 100%.
  83. Rachel Foucard uploaded patch set 23 08/22/21, 16:15

  84. core-ci voted on patch set 23 V +1 08/22/21, 16:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15397

  85. Rachel Foucard commented on patch set 23 08/22/21, 16:40

    Reply

    Done

    Reply

    Done

    Reply

    Done

    Reply

    Done

    Reply

    Done

    _page.scss:216 Reply

    done

    _page.scss:233 Reply

    Done

    _page.scss:237 Reply

    Done

    _page.scss:334 Reply

    Done
  86. Rachel Foucard commented on patch set 23 08/22/21, 16:41

    _page.scss:216 Reply

    Done

    ColumnHeader.html:18 Reply

    Done
  87. Oli Bartsch commented on patch set 23 08/23/21, 14:01

    _page.scss:63

    I think restricted and unused should still be separated. What is the reason for using the same appearance for different states?

    _page.scss:200

    Just spotted this. Since we already change huge parts of this file, we may also want to use modern techniques for positioning here.

    _page.scss:237 Reply

    Ack

    _page.scss:318

    This now only takes the "connected mode" into account. The same problem also exists in case the user does not have content edit permissions. There might be more cases. Therefore, I suggest to handle the spacing differently. Otherwise we might need to adjust this place regularly in the future.

    _page.scss:334 Reply

    Ok, so the idea is active and inactive state is indicated by the dotted border, right? if I got this right, why do the header and content section still change their opacity, while the footer does not?

    _page.scss:467

    We might use the variable here.

    StandardContentPreviewRenderer.php:255

    This represents "[ALL]". What about using the previous combination: The languages multiple icon + the "All languages" string?

    Column.html:9

    Not quite sure if this is really intended to be used as a class in the HTML markup.

    ColumnHeader.html:4 Reply

    From my experience, editors usually do not use the list module for editing page content. With this change they are now forced to use another module for this action, even if they might not be familiar with the list module since they mainly worked in the page module. Just to be clear, I don't insist on keeping this action. Just wanted to point out that this might have unintended impact for some editors.

    ColumnHeader.html:18 Reply

    Where is this defined in bootstrap? I can't find it.

    Header.html:8 Reply

    Ack

    Header.html:16 Reply

    Yes, if you would like to trigger a context menu here, a button tag should be used instead.

    Header.html:17 Reply

    Ack
  88. Rachel Foucard commented on patch set 23 08/23/21, 15:00

    ColumnHeader.html:18 Reply

    I think it comes from this one Build/node_modules/bootstrap/dist/css/bootstrap.css
  89. Rachel Foucard commented on patch set 23 08/23/21, 15:15

    ColumnHeader.html:18 Reply

    Sorry I now see that you were not talking about "text-center" but "new-ce", I was a little surprised by the question :) I will prefix the class of course!
  90. Rachel Foucard commented on patch set 23 08/23/21, 16:30

    _page.scss:63 Reply

    Now the restricted zone always inform that there is no edit access with a text in the colpos title, and the Unused area also has a clear title. The color of the colpos here is then just complementary and is relative to the information level: - error, danger, hight attention level > red - warning, medium attention level > orange - information, low attention level > blue - success > green etc. Also orange may be (to be confirmed later by the UX Initiative) the secondary color to hightlight things in the backend. The red for the restricted area was too high, there is no problem with a restricted area, there is just no edit access.

    _page.scss:318 Reply

    Yes good point, will work on that differently.

    _page.scss:334 Reply

    yes I get what you mean now, will add the footer in the opacity changing;

    StandardContentPreviewRenderer.php:255 Reply

    I wanted to put a flag at the beginning too but while testing : - when only this flag is displayed and there is no other language flag it is not clear what it represents, the text is more obvious - when there are several infos in the footer, it's better to keep the same way to display however will put back the "All languages" text instead of "[All]", it will be much better indeed.

    ColumnHeader.html:4 Reply

    I will talk about your point to other Initiative members.
  91. Rachel Foucard uploaded patch set 24 08/24/21, 21:45

  92. Rachel Foucard commented on patch set 24 08/24/21, 21:58

    Reply

    Done

    _page.scss:200 Reply

    done

    _page.scss:207 Reply

    Done

    _page.scss:318 Reply

    done

    _page.scss:334 Reply

    done

    _page.scss:467 Reply

    done

    StandardContentPreviewRenderer.php:255 Reply

    done

    GridColumnItem.php:253 Reply

    As soon as we have a clear statement on that cleaning task, this can be handled in another patch, and should not bloc this one.

    Column.html:9 Reply

    since it's not used anymore, I just removed it.

    ColumnHeader.html:4 Reply

    I proposed to the SCI members to keep the button (it's back in the code) and make a survey to decide for the next version if it's usefull or not to the editors.

    ColumnHeader.html:18 Reply

    done

    Header.html:16 Reply

    since the context menu was handle by an a tag with the original icon, to keep consistency, I added the good target to both (old icon and new more button).
  93. core-ci voted on patch set 24 V +1 08/24/21, 22:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15539

  94. Rachel Foucard uploaded patch set 25 08/25/21, 18:31

  95. core-ci voted on patch set 25 V -1 08/25/21, 18:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15622

  96. Rachel Foucard uploaded patch set 26 08/25/21, 18:49

  97. Jonas Eberle voted on patch set 26 V +1 CR +1 08/25/21, 18:59

  98. core-ci voted on patch set 26 V +1 08/25/21, 19:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15623

  99. Oli Bartsch commented on patch set 26 08/26/21, 11:39

    _page.scss:156

    Could we remove the margin top from the first child? It currently has more space than the other elements. In defLangBinding mode, I also experienced that the first "Add" and "Past" buttons are not longer overlaying the first content element (if one exists). Is this intended?

    _page.scss:207

    Sorry for the confusion. Actually I wanted to point to the usage of flex form. Using fixed pixels will lead to problems depending on the actions, being displayed. Example: Editor which does not have the permission to change the "hidden" field. In those cases the "toggle visibility button" is missing, moving the remaining buttons to the left, leaving space on the right.

    StandardContentPreviewRenderer.php:254

    I still have the feeling that this information won't be easily found by unexperienced users. Especially in case the footer also contains other information (e.g. the row description). Maybe think about adding the flag icon, to make this information more "prominent".

    BackendUtility.php:2241

    This seems to be unrelated. Is there any reason to add this in this patch? IMO if at all, this should be changed to a button, but in a separate patch. See also my other comment in the template file.

    GridColumnItem.php:226

    As mentioned in an earlier comment, this should be removed if no longer used.

    Header.html:16

    As mentioned in an earlier comment, this should IMO be a button. It does not "link" somewhere. The context menu is being triggered by an event listener, registered for the `t3js-contextmenutrigger` class. The added target (anchor) does not have any effect.

    Header.html:20

    As mentioned in an earlier comment, those "delete" getters should be removed if not longer used.
  100. André Kraus voted on patch set 26 V +1 08/26/21, 16:09

  101. Rachel Foucard uploaded patch set 27 08/26/21, 17:53

  102. Rachel Foucard commented on patch set 27 08/26/21, 17:56

    _page.scss:156 Reply

    done

    _page.scss:207 Reply

    done

    StandardContentPreviewRenderer.php:254 Reply

    done

    GridColumnItem.php:226 Reply

    done

    Header.html:20 Reply

    done
  103. core-ci voted on patch set 27 V -1 08/26/21, 17:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15685

  104. Rachel Foucard uploaded patch set 28 08/28/21, 16:04

  105. core-ci voted on patch set 28 V -1 08/28/21, 16:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15779

  106. Rachel Foucard uploaded patch set 29 08/28/21, 16:15

  107. core-ci voted on patch set 29 V -1 08/28/21, 16:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15780

  108. Rachel Foucard uploaded patch set 30 08/28/21, 16:21

  109. Rachel Foucard commented on patch set 30 08/28/21, 16:33

    BackendUtility.php:2241 Reply

    this is the html of the icon that generate the context menu on the left header of the content items in the page layout. We have added the more button on the right header of the content items with the same html. So if we have to change one, let's change both. Now all the context menus are handled by real buttons.

    Header.html:16 Reply

    done
  110. core-ci voted on patch set 30 V -1 08/28/21, 16:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15781

  111. Rachel Foucard uploaded patch set 31 08/29/21, 13:24

  112. core-ci voted on patch set 31 V -1 08/29/21, 13:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15814

  113. Rachel Foucard uploaded patch set 32 08/29/21, 14:07

  114. Rachel Foucard commented on patch set 32 08/29/21, 14:10

    BackendUtility.php:2241 Reply

    nope, finally, very bad idea... it should be done in a separate patch because this is indeed related to all the contextmenu icon in several other modules. Would be a patch for accessibility team.
  115. core-ci voted on patch set 32 V +1 08/29/21, 14:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15816

  116. Jonas Eberle uploaded patch set 33 08/30/21, 07:51

  117. core-ci voted on patch set 33 V -1 08/30/21, 08:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15842

  118. Jonas Eberle commented on patch set 33 V +1 08/30/21, 08:24

    Just rebased. Haven't checked the latest code changes.
  119. core-ci commented on patch set 33 08/30/21, 08:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15842

  120. Jonas Eberle commented on patch set 33 08/30/21, 09:28

    I don't understand the CI error. It errors on "I can see *page title* in a <h1> in the content frame" but that area was not touched. It has been run twice already and I cannot reproduce the error locally (`Build/Scripts/runTests.sh -s acceptance -p 8.0 -d mariadb -i 10.3 -c 12/13`)
  121. Rachel Foucard uploaded patch set 34 08/31/21, 14:55

  122. Rachel Foucard commented on patch set 34 08/31/21, 14:57

    Reply

    same for me, and if I download the artefacts folder, the title is displayed in the screenshot, and the h1 is correct in the html file.
  123. core-ci voted on patch set 34 V +1 08/31/21, 15:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15947

  124. Jonas Eberle voted on patch set 34 V +1 08/31/21, 15:22

  125. Rachel Foucard commented on patch set 34 08/31/21, 15:25

    Reply

    ok, core CI is happy, good for him ;) mystery unsolved...
  126. André Kraus voted on patch set 34 V +1 09/01/21, 18:39

  127. Jonas Eberle uploaded patch set 35 09/06/21, 09:17

  128. core-ci voted on patch set 35 V +1 09/06/21, 09:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16313

  129. Jonas Eberle voted on patch set 35 V +1 CR +1 09/06/21, 09:43

  130. Benni Mack uploaded patch set 36 09/08/21, 16:38

  131. core-ci voted on patch set 36 V +1 09/08/21, 16:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16421

  132. Jonas Eberle uploaded patch set 37 09/08/21, 17:48

  133. core-ci voted on patch set 37 V +1 09/08/21, 18:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16424

  134. Jonas Eberle uploaded patch set 38 09/09/21, 13:14

  1. core-ci voted on patch set 38 V +1 09/09/21, 13:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16453

  2. Jonas Eberle uploaded patch set 39 09/14/21, 18:59

  3. core-ci voted on patch set 39 V -1 09/14/21, 19:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16718

  4. Jonas Eberle uploaded patch set 40 09/14/21, 20:07

  5. core-ci voted on patch set 40 V -1 09/14/21, 20:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16720

  6. Jonas Eberle uploaded patch set 41 09/14/21, 21:30

  7. core-ci voted on patch set 41 V +1 09/14/21, 21:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16724

  8. Benni Mack uploaded patch set 42 09/16/21, 10:50

  9. core-ci voted on patch set 42 V +1 09/16/21, 11:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16791

  10. Benni Mack uploaded patch set 43 09/16/21, 13:15

  11. core-ci voted on patch set 43 V +1 09/16/21, 13:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16801

  12. Benni Mack uploaded patch set 44 09/17/21, 08:54

  13. core-ci voted on patch set 44 V +1 09/17/21, 09:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16860

  14. Georg Ringer voted on patch set 44 V +1 CR +1 09/21/21, 06:02

  15. Benni Mack commented on patch set 44 09/21/21, 08:37

    Unresolved

    The additional "CType" information isn't bullet-proof (it doesnt take the plugin labels into account), I'd rather split this change up in smaller chunks (as we've done before)
  16. Benni Mack commented on patch set 44 09/21/21, 10:11

    Header.html:3 Unresolved

    This is the place, that adds the content type (e.g. "Text & Images") to the content element. I think we could rather move this to the GridItem.php as a getter to call this, and then resolve also plugin texts. What do you think? Should we move this to a separate pre-patch @rakel?
  17. Rachel Foucard uploaded patch set 45 10/10/21, 14:58

  18. core-ci voted on patch set 45 V -1 10/10/21, 15:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17901

  19. Rachel Foucard uploaded patch set 46 10/11/21, 18:35

  20. core-ci voted on patch set 46 V -1 10/11/21, 18:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17933

  21. Rachel Foucard uploaded patch set 47 10/11/21, 19:34

  22. core-ci voted on patch set 47 V +1 10/11/21, 19:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17938

  23. Jonas Eberle uploaded patch set 48 10/12/21, 18:44

  24. core-ci voted on patch set 48 V +1 10/12/21, 19:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17990

  25. Benni Mack abandoned the change 11/11/21, 14:00

    abandoned for the time being, the patch for the pilot project is https://review.typo3.org/c/Packages/TYPO3.CMS/+/71965