70063[FEATURE] New content wizard bar with drag&drop in the page module
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 10
- Build/Sources/Sass/module/_page.scss+277 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/LayoutModule/DragDrop.ts+239 −22
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+1 −0
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php4+19 −0
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/Grid.php+25 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid.html+11 −0
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/MenuItem.html+3 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/LayoutModule/DragDrop.js+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-94630-NewContentWizardBarWithDragDropInThePageModule.rstnew+31 −0
Review log 4576
Show 3151 earlier messages
-
Rachel Foucard uploaded patch set 1 07/24/21, 09:05
-
Rachel Foucard wrote 07/24/21, 09:08
Topic set to SCI -
Rachel Foucard wrote 07/24/21, 09:09
Topic SCI removed -
Rachel Foucard wrote 07/24/21, 09:09
Topic set to sci -
core-ci voted on patch set 1 V -1 07/24/21, 09:18 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13706
-
Jonas Eberle uploaded patch set 2 07/25/21, 08:04
-
core-ci voted on patch set 2 V +1 07/25/21, 08:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13729
-
Jonas Eberle uploaded patch set 3 07/25/21, 14:00
-
core-ci voted on patch set 3 V +1 07/25/21, 14:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13736
-
Rachel Foucard uploaded patch set 4 08/25/21, 05:24
-
core-ci voted on patch set 4 V +1 08/25/21, 05:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15558
-
Rachel Foucard uploaded patch set 5 08/26/21, 00:55
-
core-ci voted on patch set 5 V +1 08/26/21, 01:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15643
-
Rachel Foucard uploaded patch set 6 08/29/21, 18:00
-
core-ci voted on patch set 6 V -1 08/29/21, 18:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15826
-
Rachel Foucard uploaded patch set 7 08/30/21, 11:42
-
core-ci voted on patch set 7 V +1 08/30/21, 11:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15857
-
Rachel Foucard uploaded patch set 8 08/31/21, 12:34
-
core-ci voted on patch set 8 V +1 08/31/21, 12:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15930
-
Björn Jacob commented on patch set 8 08/31/21, 13:17
Love it @Rachel. Nice feature. Maybe you are still on it. But on thing came into my mind by using it for the first time. When having the new bar collapsed/ minimized one should have Bootstrap tooltips while hovering the CEs. This helps to identify the CEs. Especially new editors need this not knowing all of the icons. And - for sure - having custom CEs is also a valid use case. -
Rachel Foucard uploaded patch set 9 09/01/21, 11:22
-
Rachel Foucard commented on patch set 9 09/01/21, 11:24
Reply
Hi Björn! thank you for you feed back, very good point! done -
core-ci voted on patch set 9 V +1 09/01/21, 11:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16007
-
Nikita Hovratov uploaded patch set 10 09/02/21, 10:53
-
Nikita Hovratov commented on patch set 10 09/02/21, 11:08
I really like this idea. It only needs some more polishing in the UX. For example if you drop an element, the element wizard bar closes and opens every time. Can we get rid of the animation on reload? If you open a few toggles, and switch to the small view, there is a horizontal scroll bar. Would be cool if we can remove it somehow, too. I have fixed another thing already: When closing a toggle group, it used to jump a little bit (due to collapsing margins). Tested on Firefox. -
core-ci voted on patch set 10 V +1 09/02/21, 11:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16066
-
Benni Mack commented on patch set 10 09/03/21, 09:19
Hey Rachel, just tried out the patch. A few remarks: * When in "collapsed" mode, I have a dark bar at the bottom of the new content wizard, is that intended? * When having lots of CEs on a page (let's say 5+), and I want to add a new content element at the bottom (as last CE), the scrolling behaviour is very flaky. On top: Once I dropped the CE, the page is reloaded and I don't know which element I just added and at what position. Wouldn't it be better to open the FormEngine directly - in a modal or so - after dropping the element? This way, we wouldn't need the workaround of making the element "hidden" by default. * When dropping an element, somehow the markup of the Wizard Item is added, having a strange layout which is added to the drop zone, just before the page is reloaded (noticable when you're not working locally). The reload "fixes" the issue of course. -
Benni Mack commented on patch set 10 09/03/21, 11:46
Hmm, I found another issue: When I have a page with 2 visible CEs and 2 hidden CEs and the checkbox "Show hidden content elements" is deactivated, I use the new Wizard and the new CE is always removed :( -
Rachel Foucard uploaded patch set 11 09/03/21, 14:29
-
core-ci voted on patch set 11 V -1 09/03/21, 14:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16193
-
Rachel Foucard uploaded patch set 12 09/03/21, 14:41
-
core-ci voted on patch set 12 V -1 09/03/21, 14:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16195
-
Rachel Foucard uploaded patch set 13 09/03/21, 14:51
-
Rachel Foucard commented on patch set 12 09/03/21, 14:58
Reply
Hi Benni, thank very much for the feed back: * The dark bar at the bottom is removed. * The autoscrolling on dragging a new content is now fixed (it was because of clone option). The autoscrolling is not better than before because it's the same than the moving or copying. * the page reloading problem is exactly the same than before, it's the same code for adding a new content than copying a content while dragging. I would love to correct this behaviour in another patch (task or bugfix) for both actions, if you agree with that? * for the markup on the dropzone, just before the reload, I'm on it.Reply
Hi Nikita, Thank you for the feed back: The animation as been removed on reload. The scroolbar has to be there, but it's thin and now it's only on the content listing, the expand/collapsed button is fixed now. Thank you very much for your fixin!Reply
Hi Benni, well, I wouldn't say it's a specific issue for this feature, because you have the same behaviour when you add hidden content: * when you translate * when you copy an existing content we could improve the visibility of this check box that hide the hidden contents, but IMHO it's not relative to this patch. what do you think? -
core-ci voted on patch set 13 V -1 09/03/21, 15:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16200
-
Rachel Foucard uploaded patch set 14 09/03/21, 18:20
-
core-ci voted on patch set 14 V -1 09/03/21, 18:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16210
-
Rachel Foucard uploaded patch set 15 09/04/21, 12:28
-
core-ci voted on patch set 15 V -1 09/04/21, 12:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16243
-
Rachel Foucard uploaded patch set 16 09/04/21, 13:00
-
core-ci voted on patch set 16 V -1 09/04/21, 13:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16244
-
Rachel Foucard uploaded patch set 17 09/04/21, 13:39
-
core-ci voted on patch set 17 V -1 09/04/21, 13:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16246
-
Rachel Foucard uploaded patch set 18 09/04/21, 14:02
-
core-ci voted on patch set 18 V +1 09/04/21, 14:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16250
-
Rachel Foucard uploaded patch set 19 09/04/21, 15:29
-
Rachel Foucard commented on patch set 19 09/04/21, 15:32
Reply
Hi Benni, * the page reloading is finally fixed (for both copying & new content), it wasn't so complicated. * the just dropped new content is now hidden so that we don't have the strange markup just before the reload -
core-ci voted on patch set 19 V -1 09/04/21, 15:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16260
-
Rachel Foucard uploaded patch set 20 09/04/21, 16:32
-
core-ci voted on patch set 20 V +1 09/04/21, 16:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16268
-
Rachel Foucard uploaded patch set 21 09/05/21, 09:20
-
Rachel Foucard commented on patch set 21 09/05/21, 09:23
Now the wizard bar is displayed only if the TSConfig property "disableNewContentElementWizard" is false. -
core-ci voted on patch set 21 V -1 09/05/21, 09:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16281
-
Rachel Foucard uploaded patch set 22 09/05/21, 10:06
-
core-ci voted on patch set 22 V +1 09/05/21, 10:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16283
-
Rachel Foucard uploaded patch set 23 09/05/21, 13:40
-
core-ci voted on patch set 23 V +1 09/05/21, 13:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16291
-
Jonas Eberle commented on patch set 23 V -1 CR -1 09/06/21, 10:43
Code: It needs a FEATURE.rst describing the new feature (including the new TSConfig option `disableNewContentElementWizard`). The whole .t3-grid-new-content-wizard probably needs an aria-hidden since it will increase confusion for screenreader users. I don't understand what's going on in DragDrop.ts and can't say if it is necessary, but it looks very convoluted currently. Verify: (UX) As an editor, after having learnt that I can use this to add new content in the "columns view", I wondered why I didn't have that possibility in the "language view". As an editor, I also would not immediately understand why the un-collapsed mode affects the collapsed mode. It might be easier to grasp if the icons' positions would be animated to make clear that the collapsed state is indeed the un-collapsed state - just without the section headers. The reload after having added new content feels disturbing for a modern product.PageLayoutController.php:214This can be made more clear IMHO - Suggestion: $isShowNewContentWizardBar = $this->id !== 0 && (int) $this->MOD_SETTINGS['function'] !== 2 && ! (bool)$this->modTSconfig['properties']['disableNewContentElementWizard'] ?? false // this would also handle disableNewContentElementWizard=0 if ($isShowNewContentWizardBar) { $isShowNewContentWizardBarExpanded = isset($this->getBackendUser()->uc['newcontentwizardbar']); ... }PageLayoutController.php:220Having a 'class="data-..."' instead of 'data-...' on an HTML element feels wrong. Are there other options? -
Rachel Foucard uploaded patch set 24 09/06/21, 19:41
-
core-ci voted on patch set 24 V +1 09/06/21, 19:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16348
-
Rachel Foucard uploaded patch set 25 09/06/21, 20:28
-
core-ci voted on patch set 25 V +1 09/06/21, 20:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16354
-
Rachel Foucard uploaded patch set 26 09/06/21, 21:11
-
core-ci voted on patch set 26 V +1 09/06/21, 21:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16355
-
Rachel Foucard uploaded patch set 27 09/06/21, 22:15
-
core-ci voted on patch set 27 V -1 09/06/21, 22:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16356
-
Rachel Foucard uploaded patch set 28 09/06/21, 22:43
-
core-ci voted on patch set 28 V -1 09/06/21, 22:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16357
-
Rachel Foucard uploaded patch set 29 09/06/21, 22:56
-
core-ci voted on patch set 29 V -1 09/06/21, 23:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16358
-
Rachel Foucard commented on patch set 29 09/06/21, 23:07
Reply
Hi Jonas, * added the feature rst * added aria-hidden * improved the DragDrop.ts code to be easier to review (hope so) * the wizard is disabled for language module because the way the d&d was initially coded, it's not possible to guess the language of the new content before it's dropped. But showing the behaviour in this post it didn't seem to hurt so much? (https://twitter.com/FoucardRachel/status/1434532670281764868) * improved the collapsed/expand action with a smoother effect * the reload is the same behaviour than the copy action and it has been improved with this patch because now it keeps the scroll position.PageLayoutController.php:214Replythank you very much for the suggestion! donePageLayoutController.php:220Replyof course, I don't know why I named this class like this! done -
Rachel Foucard uploaded patch set 30 09/06/21, 23:10
-
core-ci voted on patch set 30 V -1 09/06/21, 23:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16359
-
Rachel Foucard uploaded patch set 31 09/07/21, 00:17
-
core-ci voted on patch set 31 V +1 09/07/21, 00:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16360
-
Benni Mack abandoned the change 11/11/21, 14:00
abandoned for the time being, the patch for the pilot project is https://review.typo3.org/c/Packages/TYPO3.CMS/+/71965