Review main Merged

70065[TASK] Replace GU::getIndpEnv('TYPO3_SITE_URL')

Anja Leichsenring CR +2 V +2 Normal +57 −33 updated 08/23/21, 18:40

Commit message

The information is available in the request and should be used from there.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 3653

Show 1628 earlier messages
  1. Anja Leichsenring uploaded patch set 1 07/24/21, 13:15

  2. core-ci voted on patch set 1 V +1 07/24/21, 13:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13712

  3. Anja Leichsenring uploaded patch set 2 07/24/21, 13:36

  4. core-ci voted on patch set 2 V -1 07/24/21, 13:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13713

  5. Anja Leichsenring uploaded patch set 3 07/24/21, 14:00

  6. core-ci voted on patch set 3 V +1 07/24/21, 14:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13714

  7. Anja Leichsenring uploaded patch set 4 07/24/21, 14:14

  8. core-ci voted on patch set 4 V +1 07/24/21, 14:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13715

  9. Anja Leichsenring uploaded patch set 5 07/24/21, 14:29

  10. core-ci voted on patch set 5 V +1 07/24/21, 14:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13716

  11. Anja Leichsenring uploaded patch set 6 07/24/21, 14:53

  12. Anja Leichsenring uploaded patch set 7 07/24/21, 15:02

  13. core-ci voted on patch set 6 V -1 07/24/21, 15:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13717

  14. Anja Leichsenring uploaded patch set 8 07/24/21, 15:05

  15. core-ci voted on patch set 7 V -1 07/24/21, 15:14 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13718

  16. Anja Leichsenring uploaded patch set 9 07/24/21, 16:02

  17. core-ci voted on patch set 9 V -1 07/24/21, 16:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13720

  18. Anja Leichsenring uploaded patch set 10 07/24/21, 16:24

  19. core-ci voted on patch set 10 V +1 07/24/21, 16:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13721

  20. Anja Leichsenring uploaded patch set 11 07/25/21, 07:14

  21. Anja Leichsenring uploaded patch set 12 07/25/21, 07:17

  22. Anja Leichsenring uploaded patch set 13 07/25/21, 07:22

  23. core-ci voted on patch set 12 V +1 07/25/21, 07:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13726

  24. core-ci voted on patch set 13 V +1 07/25/21, 07:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13727

  25. Anja Leichsenring uploaded patch set 14 07/25/21, 07:43

  26. Anja Leichsenring commented on patch set 14 07/25/21, 07:44

    This change is ready for review.
  27. core-ci voted on patch set 14 V +1 07/25/21, 07:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13728

  28. Oli Bartsch commented on patch set 14 07/27/21, 10:13

    We shouldn't touch the changelog files since AFAIK $GLOBALS['TYPO3_REQUEST'] does not exists in those versions.
  1. Anja Leichsenring commented on patch set 14 07/27/21, 16:04

    Reply

    good point, I will change it
  2. Anja Leichsenring uploaded patch set 15 07/27/21, 16:11

  3. core-ci voted on patch set 15 V +1 07/27/21, 16:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13818

  4. Jörg Bösche voted on patch set 15 CR +1 08/06/21, 07:39

  5. Christian Kuhn commented on patch set 15 08/07/21, 11:40

    TestTask.php:60

    this fails on CLI. it's imho a bad idea to use that information here in the first place. can't we put some other info in there? maybe sitename from typo3_conf_vars? would be better anyways, i'd argue.
  6. Christian Kuhn commented on patch set 15 08/08/21, 13:10

  7. Anja Leichsenring uploaded patch set 16 08/09/21, 17:21

  8. core-ci voted on patch set 16 V +1 08/09/21, 17:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14386

  9. Wouter Wolters voted on patch set 16 CR +1 08/10/21, 09:11

  10. crell voted on patch set 16 CR +1 08/19/21, 18:53

  11. Markus Klein commented on patch set 16 08/19/21, 19:57

    BackendUserAuthentication.php:2123 Unresolved

    I don't get the comment. Why is this never reached by core code?
  12. Anja Leichsenring uploaded patch set 17 08/23/21, 15:58

  13. crell voted on patch set 17 CR +1 08/23/21, 16:18

  14. core-ci voted on patch set 17 V -1 08/23/21, 16:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15418

  15. core-ci voted on patch set 17 V +1 08/23/21, 16:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15418

  16. Stefan Bürk voted on patch set 17 CR +1 08/23/21, 16:36

  17. Wouter Wolters voted on patch set 17 CR +1 08/23/21, 17:43

  18. Anja Leichsenring uploaded patch set 18 08/23/21, 18:15

  19. Christian Kuhn commented on patch set 18 V +1 CR +1 08/23/21, 18:17

    RedirectUrlValidatorTest.php:79

    should be obsolete since unit tests run backupGlobals = true ... but does not harm too much, either.
  20. Wouter Wolters voted on patch set 18 CR +1 08/23/21, 18:18

  21. Anja Leichsenring commented on patch set 18 08/23/21, 18:20

    RedirectUrlValidatorTest.php:79 Reply

    done
  22. Stefan Bürk voted on patch set 18 V +1 CR +1 08/23/21, 18:34

  23. core-ci voted on patch set 18 V +1 08/23/21, 18:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15439

  24. Christian Kuhn voted on patch set 18 V +2 CR +2 08/23/21, 18:40

  25. Christian Kuhn merged patch set 19 08/23/21, 18:40