70065[TASK] Replace GU::getIndpEnv('TYPO3_SITE_URL')
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php1+1 −1
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+2 −2
- typo3/sysext/core/Tests/Unit/Domain/Repository/PageRepositoryTest.php+10 −2
- typo3/sysext/extbase/Classes/Mvc/View/NotFoundView.php+1 −2
- typo3/sysext/felogin/Classes/Validation/RedirectUrlValidator.php+6 −2
- typo3/sysext/felogin/Tests/Unit/Validation/RedirectUrlValidatorTest.php2+16 −0
- typo3/sysext/indexed_search/Classes/Indexer.php+1 −1
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+12 −2
- typo3/sysext/install/Classes/ViewHelpers/Uri/ActionViewHelper.php+2 −15
- typo3/sysext/linkvalidator/Classes/Linktype/FileLinktype.php+1 −1
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+1 −1
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+1 −1
- typo3/sysext/t3editor/Resources/Private/tsref.xml+2 −2
Review log 3653
Show 1628 earlier messages
-
Anja Leichsenring uploaded patch set 1 07/24/21, 13:15
-
core-ci voted on patch set 1 V +1 07/24/21, 13:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13712
-
Anja Leichsenring uploaded patch set 2 07/24/21, 13:36
-
core-ci voted on patch set 2 V -1 07/24/21, 13:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13713
-
Anja Leichsenring uploaded patch set 3 07/24/21, 14:00
-
core-ci voted on patch set 3 V +1 07/24/21, 14:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13714
-
Anja Leichsenring uploaded patch set 4 07/24/21, 14:14
-
core-ci voted on patch set 4 V +1 07/24/21, 14:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13715
-
Anja Leichsenring uploaded patch set 5 07/24/21, 14:29
-
core-ci voted on patch set 5 V +1 07/24/21, 14:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13716
-
Anja Leichsenring uploaded patch set 6 07/24/21, 14:53
-
Anja Leichsenring uploaded patch set 7 07/24/21, 15:02
-
core-ci voted on patch set 6 V -1 07/24/21, 15:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13717
-
Anja Leichsenring uploaded patch set 8 07/24/21, 15:05
-
core-ci voted on patch set 7 V -1 07/24/21, 15:14 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13718
-
Anja Leichsenring uploaded patch set 9 07/24/21, 16:02
-
core-ci voted on patch set 9 V -1 07/24/21, 16:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13720
-
Anja Leichsenring uploaded patch set 10 07/24/21, 16:24
-
core-ci voted on patch set 10 V +1 07/24/21, 16:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13721
-
Anja Leichsenring uploaded patch set 11 07/25/21, 07:14
-
Anja Leichsenring uploaded patch set 12 07/25/21, 07:17
-
Anja Leichsenring uploaded patch set 13 07/25/21, 07:22
-
core-ci voted on patch set 12 V +1 07/25/21, 07:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13726
-
core-ci voted on patch set 13 V +1 07/25/21, 07:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13727
-
Anja Leichsenring uploaded patch set 14 07/25/21, 07:43
-
Anja Leichsenring commented on patch set 14 07/25/21, 07:44
This change is ready for review. -
core-ci voted on patch set 14 V +1 07/25/21, 07:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13728
-
Oli Bartsch commented on patch set 14 07/27/21, 10:13
We shouldn't touch the changelog files since AFAIK $GLOBALS['TYPO3_REQUEST'] does not exists in those versions.
-
Anja Leichsenring commented on patch set 14 07/27/21, 16:04
Reply
good point, I will change it -
Anja Leichsenring uploaded patch set 15 07/27/21, 16:11
-
core-ci voted on patch set 15 V +1 07/27/21, 16:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13818
-
Jörg Bösche voted on patch set 15 CR +1 08/06/21, 07:39
-
Christian Kuhn commented on patch set 15 08/07/21, 11:40
TestTask.php:60this fails on CLI. it's imho a bad idea to use that information here in the first place. can't we put some other info in there? maybe sitename from typo3_conf_vars? would be better anyways, i'd argue. -
Christian Kuhn commented on patch set 15 08/08/21, 13:10
TestTask.php:60Reply -
Anja Leichsenring uploaded patch set 16 08/09/21, 17:21
-
core-ci voted on patch set 16 V +1 08/09/21, 17:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14386
-
Wouter Wolters voted on patch set 16 CR +1 08/10/21, 09:11
-
crell voted on patch set 16 CR +1 08/19/21, 18:53
-
Markus Klein commented on patch set 16 08/19/21, 19:57
BackendUserAuthentication.php:2123UnresolvedI don't get the comment. Why is this never reached by core code? -
Anja Leichsenring uploaded patch set 17 08/23/21, 15:58
-
crell voted on patch set 17 CR +1 08/23/21, 16:18
-
core-ci voted on patch set 17 V -1 08/23/21, 16:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15418
-
core-ci voted on patch set 17 V +1 08/23/21, 16:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15418
-
Stefan Bürk voted on patch set 17 CR +1 08/23/21, 16:36
-
Wouter Wolters voted on patch set 17 CR +1 08/23/21, 17:43
-
Anja Leichsenring uploaded patch set 18 08/23/21, 18:15
-
Christian Kuhn commented on patch set 18 V +1 CR +1 08/23/21, 18:17
RedirectUrlValidatorTest.php:79should be obsolete since unit tests run backupGlobals = true ... but does not harm too much, either. -
Wouter Wolters voted on patch set 18 CR +1 08/23/21, 18:18
-
Anja Leichsenring commented on patch set 18 08/23/21, 18:20
RedirectUrlValidatorTest.php:79Replydone -
Stefan Bürk voted on patch set 18 V +1 CR +1 08/23/21, 18:34
-
core-ci voted on patch set 18 V +1 08/23/21, 18:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15439
-
Christian Kuhn voted on patch set 18 V +2 CR +2 08/23/21, 18:40
-
Christian Kuhn merged patch set 19 08/23/21, 18:40