Review main Merged

70066[BUGFIX] Fix #modulemenu collapsed state on Firefox

Jonas Eberle CR +2 V +2 Easy +2 −2 updated 07/30/21, 06:50

Commit message

Due to different handling of scrollbar positioning and layouting in
user agents (most use the operating system's graphics stack to show
scrollbars, Chrome its own) it could happen that the modulebar icons
were shown partially only.

It should not be relied on the width of scrollbars and if they affect
the user agent's box model or not.

In our case an inner element was pixel-perfectly relying on parent
elements' box sizes since #93353.

This dependency has been removed for the collapsed state.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Jonas Eberle uploaded patch set 1 07/25/21, 10:47

  2. core-ci voted on patch set 1 V +1 07/25/21, 11:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13733

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 07/29/21, 20:43

  4. Benni Mack voted on patch set 1 V +2 CR +2 07/30/21, 06:50

  5. Benni Mack merged patch set 2 07/30/21, 06:50