Review main Merged

70068[BUGFIX] Check whether realpath exists in runTests.sh

Oli Bartsch CR +2 V +2 Easy +8 −1 updated 07/27/21, 09:59

Commit message

#94612 introduced the realpath command for retrieving
the "CORE_ROOT" path. This however leads to execution
failures on MacOS systems, which did not manually install
this command (as it's not installed by default).

To prevent the script from failing on default MacOS systems,
a check for the existence of the realpath command is added.
If not installed, the previous behaviour is used while displaying
a short information.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 07/26/21, 08:53

  2. Oli Bartsch updated the commit message in patch set 2 07/26/21, 08:57

  3. core-ci voted on patch set 1 V +1 07/26/21, 09:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13741

  4. core-ci voted on patch set 2 V +1 07/26/21, 09:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13742

  5. Jochen Roth voted on patch set 2 V +1 CR +1 07/26/21, 09:12

  6. Benni Mack voted on patch set 2 V +1 CR +1 07/27/21, 07:05

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 07/27/21, 09:59

  8. Oli Bartsch merged patch set 3 07/27/21, 09:59