70069[FEATURE] Introduce sliding window pagination
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Torben Hansen +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2634
Show 69 earlier messages
-
Eric Chavaillaz uploaded patch set 1 07/26/21, 09:21
-
Mathias Brodala commented on patch set 1 07/26/21, 09:24
This should be "windowed" / "window" instead. -
Eric Chavaillaz uploaded patch set 2 07/26/21, 09:33
-
core-ci voted on patch set 1 V +1 07/26/21, 09:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13743
-
Mathias Brodala commented on patch set 2 07/26/21, 09:43
Feature-94625-IntroduceNumberedPagination.rst:19This and all other occurrences should be updated, too. ;-) (Including the RST filename.) -
core-ci voted on patch set 2 V +1 07/26/21, 09:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13744
-
Eric Chavaillaz uploaded patch set 3 07/26/21, 09:50
-
core-ci voted on patch set 3 V +1 07/26/21, 10:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13745
-
Benni Mack commented on patch set 3 07/30/21, 11:03
I somehow fail to understand why it is called "Window Pagination", I always think of windows / tabs etc. Should we come up with a better name? Maybe look at other systems / CMS / frameworks on how to name it? Or is it just me?
-
Mathias Brodala commented on patch set 3 07/30/21, 12:12
Reply
Some call it "window": https://laravel.com/docs/8.x/pagination#adjusting-the-pagination-link-window Also common seems to be "range": https://packagist.org/packages/knplabs/knp-paginator-bundle https://docs.laminas.dev/laminas-paginator/configuration/ Some even don't have a name at all: https://developer.wordpress.org/reference/functions/paginate_links/ I'd be happy with anything besides just "number". -
Mathias Brodala commented on patch set 3 07/30/21, 12:14
Reply
The term "window" here should stem from the "sliding window algorithm": https://stackoverflow.com/questions/8269916/what-is-sliding-window-algorithm-examples -
Torben Hansen commented on patch set 3 08/01/21, 10:53
Should'nt we use typed properties (e.g. protected int $displayRangeStart = 0;) for all properties in the WindowPagination class? I also suggest to call the class "SlidingWindowPagination". -
Eric Chavaillaz uploaded patch set 4 08/01/21, 10:59
-
Torben Hansen commented on patch set 4 08/01/21, 11:06
WindowPagination.php:24Should be: protected bool $hasLessPages = false;WindowPagination.php:25protected bool $hasMorePages = false; -
Eric Chavaillaz uploaded patch set 5 08/01/21, 11:11
-
Eric Chavaillaz uploaded patch set 6 08/01/21, 11:13
-
core-ci voted on patch set 4 V -1 08/01/21, 11:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13957
-
core-ci commented on patch set 5 08/01/21, 11:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13959
-
core-ci voted on patch set 6 V +1 08/01/21, 11:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13960
-
Torben Hansen commented on patch set 6 09/30/21, 18:05
WindowPagination.php:24ReplyDoneWindowPagination.php:25ReplyDone -
Mathias Brodala commented on patch set 6 10/01/21, 07:04
Reply
DoneReply
DoneFeature-94625-IntroduceNumberedPagination.rst:19ReplyDone -
Torben Hansen voted on patch set 6 V +1 CR +1 10/01/21, 07:54
-
Simon Schaufelberger commented on patch set 6 CR -1 10/01/21, 12:07
The file name should also be renamed to NumberedPagination as WindowPagination is a very misleading name -
Mathias Brodala commented on patch set 6 10/01/21, 13:04
Reply
But it's actually closer to the most important feature: a sliding window of pages. Without the window I'd agree that you have a numbered pagination. But that's what we already have without this change. -
Torben Hansen uploaded patch set 7 10/01/21, 13:15
-
Mathias Brodala voted on patch set 7 CR +1 10/01/21, 13:22
-
Torben Hansen commented on patch set 7 V +1 CR +1 10/01/21, 13:30
Reply
I think SlidingWindowPagination fits best. -
core-ci voted on patch set 7 V +1 10/01/21, 13:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17431
-
Oli Bartsch uploaded patch set 8 11/19/21, 14:51
-
core-ci voted on patch set 8 V +1 11/19/21, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19565
-
Oli Bartsch voted on patch set 8 V +1 CR +1 11/19/21, 15:11
-
Torben Hansen voted on patch set 8 V +1 CR +1 11/19/21, 15:24
-
Georg Ringer voted on patch set 8 V +2 CR +2 11/19/21, 16:10
-
Georg Ringer merged patch set 9 11/19/21, 16:10