Review main Merged

70069[FEATURE] Introduce sliding window pagination

Eric Chavaillaz CR +2 V +2 Hard +362 −0 updated 11/19/21, 16:10

Commit message

This adds the NumberedPagination class from the
ext:numbered_pagination of Georg Ringer as
"SlidingWindowPagination" to the Core.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2634

Show 69 earlier messages
  1. Eric Chavaillaz uploaded patch set 1 07/26/21, 09:21

  2. Mathias Brodala commented on patch set 1 07/26/21, 09:24

    This should be "windowed" / "window" instead.
  3. Eric Chavaillaz uploaded patch set 2 07/26/21, 09:33

  4. core-ci voted on patch set 1 V +1 07/26/21, 09:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13743

  5. Mathias Brodala commented on patch set 2 07/26/21, 09:43

    Feature-94625-IntroduceNumberedPagination.rst:19

    This and all other occurrences should be updated, too. ;-) (Including the RST filename.)
  6. core-ci voted on patch set 2 V +1 07/26/21, 09:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13744

  7. Eric Chavaillaz uploaded patch set 3 07/26/21, 09:50

  8. core-ci voted on patch set 3 V +1 07/26/21, 10:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13745

  9. Benni Mack commented on patch set 3 07/30/21, 11:03

    I somehow fail to understand why it is called "Window Pagination", I always think of windows / tabs etc. Should we come up with a better name? Maybe look at other systems / CMS / frameworks on how to name it? Or is it just me?
  1. Mathias Brodala commented on patch set 3 07/30/21, 12:12

  2. Mathias Brodala commented on patch set 3 07/30/21, 12:14

    Reply

    The term "window" here should stem from the "sliding window algorithm": https://stackoverflow.com/questions/8269916/what-is-sliding-window-algorithm-examples
  3. Torben Hansen commented on patch set 3 08/01/21, 10:53

    Should'nt we use typed properties (e.g. protected int $displayRangeStart = 0;) for all properties in the WindowPagination class? I also suggest to call the class "SlidingWindowPagination".
  4. Eric Chavaillaz uploaded patch set 4 08/01/21, 10:59

  5. Torben Hansen commented on patch set 4 08/01/21, 11:06

    WindowPagination.php:24

    Should be: protected bool $hasLessPages = false;

    WindowPagination.php:25

    protected bool $hasMorePages = false;
  6. Eric Chavaillaz uploaded patch set 5 08/01/21, 11:11

  7. Eric Chavaillaz uploaded patch set 6 08/01/21, 11:13

  8. core-ci voted on patch set 4 V -1 08/01/21, 11:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13957

  9. core-ci commented on patch set 5 08/01/21, 11:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13959

  10. core-ci voted on patch set 6 V +1 08/01/21, 11:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13960

  11. Torben Hansen commented on patch set 6 09/30/21, 18:05

    WindowPagination.php:24 Reply

    Done

    WindowPagination.php:25 Reply

    Done
  12. Mathias Brodala commented on patch set 6 10/01/21, 07:04

    Reply

    Done

    Reply

    Done

    Feature-94625-IntroduceNumberedPagination.rst:19 Reply

    Done
  13. Torben Hansen voted on patch set 6 V +1 CR +1 10/01/21, 07:54

  14. Simon Schaufelberger commented on patch set 6 CR -1 10/01/21, 12:07

    The file name should also be renamed to NumberedPagination as WindowPagination is a very misleading name
  15. Mathias Brodala commented on patch set 6 10/01/21, 13:04

    Reply

    But it's actually closer to the most important feature: a sliding window of pages. Without the window I'd agree that you have a numbered pagination. But that's what we already have without this change.
  16. Torben Hansen uploaded patch set 7 10/01/21, 13:15

  17. Mathias Brodala voted on patch set 7 CR +1 10/01/21, 13:22

  18. Torben Hansen commented on patch set 7 V +1 CR +1 10/01/21, 13:30

    Reply

    I think SlidingWindowPagination fits best.
  19. core-ci voted on patch set 7 V +1 10/01/21, 13:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17431

  20. Oli Bartsch uploaded patch set 8 11/19/21, 14:51

  21. core-ci voted on patch set 8 V +1 11/19/21, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19565

  22. Oli Bartsch voted on patch set 8 V +1 CR +1 11/19/21, 15:11

  23. Torben Hansen voted on patch set 8 V +1 CR +1 11/19/21, 15:24

  24. Georg Ringer voted on patch set 8 V +2 CR +2 11/19/21, 16:10

  25. Georg Ringer merged patch set 9 11/19/21, 16:10