Review main Merged

70070[TASK] Add NEON files to .editorconfig

Simon Gilli CR +2 V +2 Easy +5 −0 updated 07/29/21, 10:26

Commit message

The NEON files are currently missing in the .editorconfig
and properly added by this patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • crell +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Simon Gilli uploaded patch set 1 07/26/21, 12:31

  2. core-ci voted on patch set 1 V +1 07/26/21, 12:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13759

  3. crell voted on patch set 1 CR +1 07/26/21, 14:22

  4. Benni Mack commented on patch set 1 07/26/21, 16:47

    There are no core files with ".neon" in 9.5. Any reason to backport this?
  5. Simon Gilli updated the commit message in patch set 2 07/27/21, 09:08

  6. Simon Gilli commented on patch set 2 07/27/21, 09:09

    Reply

    Oops, no absolutely not. Removed the 9.5 backport.
  7. core-ci voted on patch set 2 V +1 07/27/21, 09:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13796

  8. Benni Mack voted on patch set 2 V +1 CR +1 07/27/21, 11:22

  9. crell voted on patch set 2 CR +1 07/27/21, 15:05

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 07/29/21, 10:26

  11. Christian Kuhn merged patch set 3 07/29/21, 10:26