Review main Abandoned

70071[BUGFIX] Lookup tables count with correct DB connection

Helmut Hummel CR 0 V 0 Easy +9 −27 updated 10/07/21, 13:26

Commit message

When configuring a TYPO3 table to be on a different connection,
it is important to not check for a record count for this
table on the new connection when doing a schema compare,
because the table does not exist there yet.

Therefore the record count must be performed on the connection
for which this schema diff is created.

Additionally do not filter tables not related to a connection,
to be able to create a schema diff for tables to be removed
once mapping for the table changed or the table mapped to
a not default connection is not required any more.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1015

  1. Helmut Hummel uploaded patch set 1 07/26/21, 14:51

  2. Helmut Hummel rebased onto patch set 2 07/26/21, 14:51

  3. core-ci voted on patch set 1 V +1 07/26/21, 15:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13765

  4. core-ci voted on patch set 2 V +1 07/26/21, 15:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13766

  5. Benni Mack voted on patch set 2 CR +1 07/26/21, 15:21

  6. Nikita Hovratov commented on patch set 2 07/26/21, 15:54

    typo: this
  7. Helmut Hummel uploaded patch set 3 07/26/21, 15:57

  8. Helmut Hummel updated the commit message in patch set 4 07/26/21, 15:58

  9. Helmut Hummel commented on patch set 4 07/26/21, 15:58

    Reply

    Done
  10. core-ci voted on patch set 3 V -1 07/26/21, 16:00 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13776

  11. core-ci voted on patch set 4 V -1 07/26/21, 16:01 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13777

  12. Helmut Hummel uploaded patch set 5 07/26/21, 16:03

  13. Helmut Hummel commented on patch set 4 CR -2 07/26/21, 16:10

    That does not work unfortunately
  14. core-ci voted on patch set 5 V -1 07/26/21, 16:16 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13779

  15. Helmut Hummel abandoned the change 10/07/21, 13:26

    not worth fixing