Review main Merged

70112[BUGFIX] Streamline mount page resolving for HMENU special=list

Benni Mack CR +2 V +2 Normal +25 −40 updated 07/29/21, 15:52

Commit message

TYPO3 used RelationHandler for HMENU special=list to
fetch all pages for this menu once, but fetched
the full records again for MountPoint relation, and
manual language + workspace overlay was taken care later-on.

Once menus were generated with mountpoints and workspace and language
overlays, the ordering was not in line, and existing
queries were not used.

Instead, the code is now simplified and fully relies on
PageRepository functionality, just as most other
Frontend-related code.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1420

  1. Benni Mack uploaded patch set 1 07/27/21, 08:00

  2. core-ci voted on patch set 1 V -1 07/27/21, 08:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13793

  3. Benni Mack uploaded patch set 2 07/27/21, 08:37

  4. core-ci voted on patch set 2 V +1 07/27/21, 08:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13794

  5. Benni Mack uploaded patch set 3 07/27/21, 09:18

  6. Benni Mack uploaded patch set 4 07/27/21, 09:27

  7. core-ci voted on patch set 3 V +1 07/27/21, 09:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13797

  8. core-ci voted on patch set 4 V +1 07/27/21, 09:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13798

  9. Nikita Hovratov commented on patch set 4 07/27/21, 10:50

    AbstractMenuContentObject.php:726

    Is this really needed? GeneralUtility::intExplode should ensure ints.

    AbstractMenuContentObject.php:742

    Comment needs adjustments, as we now use continue instead of unset.
  10. Benni Mack commented on patch set 5 07/27/21, 11:18

    Published edit on patch set 4.
  11. Benni Mack commented on patch set 5 07/27/21, 11:18

    AbstractMenuContentObject.php:726 Reply

    Thanks, I had trimExplode() in the beginning.

    AbstractMenuContentObject.php:742 Reply

    done
  12. core-ci voted on patch set 5 V +1 07/27/21, 11:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13809

  13. Nikita Hovratov uploaded patch set 6 07/27/21, 11:30

  14. Nikita Hovratov voted on patch set 6 CR +1 07/27/21, 11:31

  15. core-ci voted on patch set 6 V +1 07/27/21, 11:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13810

  16. Oli Bartsch voted on patch set 6 CR +1 07/27/21, 23:14

  17. Christian Kuhn voted on patch set 6 V +1 CR +1 07/29/21, 14:50

  18. Oli Bartsch voted on patch set 6 V +1 07/29/21, 15:26

  19. Benni Mack voted on patch set 6 V +2 CR +2 07/29/21, 15:52

  20. Benni Mack merged patch set 7 07/29/21, 15:52