Review main Merged

70115[BUGFIX] Allow slashes as TS keys and escape dots for generated TS

Helmut Hummel CR +2 V +2 Normal +219 −8 updated 11/17/21, 10:14

Commit message

With the introduction of site settings being exposed
to TypoScript with https://review.typo3.org/64128
it has become important to allow more characters
as TypoScript keys. Allowing a slash in addition should
cover cases where paths are exposed as keys.

Additionally the above change reveals, that the
ArrayUtility::flatten method does not properly handle
array keys that has dots in between, as those must
be escaped to produce a correct result.

This change introduces a new flatten method after
several failed attempts to guess what fixes might
not be breaking.

The new method is used in places where no TypoScript
is used, as in those the weird edge case behaviour
of the flatten method isn't expected anyway.

The new method is marked internal until it is decided
how to proceed with the flatten method.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1423

  1. Helmut Hummel uploaded patch set 1 07/27/21, 10:35

  2. Helmut Hummel uploaded patch set 2 07/27/21, 10:51

  3. Helmut Hummel uploaded patch set 3 07/27/21, 11:02

  4. core-ci voted on patch set 1 V -1 07/27/21, 12:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13804

  5. core-ci voted on patch set 2 V -1 07/27/21, 12:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13807

  6. core-ci voted on patch set 3 V -1 07/27/21, 13:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13808

  7. Benni Mack uploaded patch set 4 10/20/21, 15:50

  8. Benni Mack commented on patch set 4 10/20/21, 15:50

    Just rebased for now. I think if we look in forge, we will find a ton of other issues related to this bugfix.
  9. core-ci voted on patch set 4 V -1 10/20/21, 16:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18388

  10. Helmut Hummel uploaded patch set 5 10/27/21, 14:04

  11. core-ci voted on patch set 5 V -1 10/27/21, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18620

  12. Helmut Hummel uploaded patch set 6 10/27/21, 14:09

  13. core-ci voted on patch set 6 V -1 10/27/21, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18622

  14. Helmut Hummel uploaded patch set 7 10/28/21, 08:26

  15. core-ci voted on patch set 7 V -1 10/28/21, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18640

  16. Helmut Hummel uploaded patch set 8 10/28/21, 08:49

  17. core-ci voted on patch set 8 V -1 10/28/21, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18642

  18. Helmut Hummel uploaded patch set 9 11/02/21, 11:10

  19. core-ci voted on patch set 9 V +1 11/02/21, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18746

  20. Benni Mack voted on patch set 9 V +1 CR +1 11/04/21, 10:59

  21. Oli Bartsch voted on patch set 9 V +1 CR +1 11/16/21, 22:43

  22. Helmut Hummel voted on patch set 9 V +2 CR +2 11/17/21, 10:14

  23. Helmut Hummel merged patch set 10 11/17/21, 10:14