Review main Merged

70116[BUGFIX] Use proper driver for FAL isWithin() check

Tim Schreiner CR +2 V +2 Easy +1 −1 updated 10/17/21, 19:45

Commit message

When checking if an identifier is within the processing folder,
the processing folders driver is used instead of current driver.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Tim Schreiner uploaded patch set 1 07/27/21, 10:49

  2. Tim Schreiner updated the commit message in patch set 2 07/27/21, 10:50

  3. core-ci voted on patch set 2 V +1 07/27/21, 11:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13806

  4. core-ci voted on patch set 1 V +1 07/27/21, 11:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13805

  5. Christian Kuhn uploaded patch set 3 07/29/21, 20:32

  6. Christian Kuhn commented on patch set 3 CR +1 07/29/21, 20:33

    I'm not an FAL expert, but this looks legit. Anyone else to confirm?
  7. core-ci voted on patch set 3 V +1 07/29/21, 20:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13902

  8. Benni Mack voted on patch set 3 CR +1 07/30/21, 06:49

  9. Guido Schmechel voted on patch set 3 CR +1 07/30/21, 23:23

  10. Nikita Hovratov commented on patch set 3 V -1 08/30/21, 15:04

    I don't think this is necessary. The ResourceStorage only has processingFolders of the same storage and thus all drivers are the same. See getProcessingFolders method. @Tim Schreiner, did you have an actual issue where the drivers were different?
  11. Tim Schreiner commented on patch set 3 08/31/21, 16:31

    Reply

    This issue came to me while I was working on a new FAL driver for a client. But this driver does not use "classical" folder identifiers (names) but combined IDs that are needed for an API. This driver currently requires the processing folder to be pointing to another folder. Therefore I expected to never to receive the Processing folder identifier as an argument to my drivers isWithin. I expect only identifiers that follows the drivers special file or folder identifier scheme. I know this is an absolute edge case. But this change will apply the expected bevaviour of the processed folder when writing FAL drivers.
  12. Nikita Hovratov commented on patch set 3 V +1 CR +1 08/31/21, 17:01

    Reply Unresolved

    Okay, I guess it's fine then. For the core itself this changes nothing as far as my tests went.
  13. Stefan Bürk voted on patch set 3 V +1 CR +1 10/17/21, 19:44

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 10/17/21, 19:45

  15. Christian Kuhn merged patch set 4 10/17/21, 19:45