Review main Merged

70117[BUGFIX] Improve loading of related records in Backend UI

Benni Mack CR +2 V +2 Hard +213 −470 updated 07/29/21, 15:48

Commit message

This change uses RelationHandler for foreign_table / allowed and MM
in BackendUtility::getProcessedValue in a consistent way.

In addition, the RelationHandler now fetches the full
record by default and adds this to the processed array, making
fewer queries to the database by fetching each record
fully directly.

Some bugs are fixed with that:
* FAL images (as in all inline fields) in list module now have the correct order
* Fewer DB queries when fetching relations in Group field in FormEngine

Setting the option in RelationHandler to fetch all fields by default
avoids unneeded calls in general when fetching the records.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1423

  1. Benni Mack uploaded patch set 1 07/27/21, 14:22

  2. core-ci voted on patch set 1 V -1 07/27/21, 14:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13812

  3. Benni Mack uploaded patch set 2 07/27/21, 14:56

  4. core-ci voted on patch set 2 V -1 07/27/21, 15:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13815

  5. Oli Bartsch uploaded patch set 3 07/27/21, 22:15

  6. core-ci voted on patch set 3 V -1 07/27/21, 22:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13825

  7. Oli Bartsch uploaded patch set 4 07/27/21, 22:40

  8. core-ci voted on patch set 4 V +1 07/27/21, 22:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13826

  9. Benni Mack updated the commit message in patch set 5 07/28/21, 06:40

  10. Benni Mack updated the commit message in patch set 6 07/28/21, 06:49

  11. core-ci voted on patch set 5 V +1 07/28/21, 06:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13831

  12. core-ci voted on patch set 6 V +1 07/28/21, 07:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13832

  13. Oli Bartsch uploaded patch set 7 07/28/21, 07:43

  14. Oli Bartsch voted on patch set 7 V +1 CR +1 07/28/21, 07:44

  15. core-ci voted on patch set 7 V +1 07/28/21, 07:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13833

  16. Benni Mack uploaded patch set 8 07/28/21, 12:17

  17. core-ci voted on patch set 8 V +1 07/28/21, 12:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13843

  18. Oli Bartsch voted on patch set 8 V +1 CR +1 07/28/21, 12:41

  19. Benni Mack uploaded patch set 9 07/29/21, 11:28

  20. core-ci voted on patch set 9 V +1 07/29/21, 11:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13873

  21. Oli Bartsch voted on patch set 9 V +1 CR +1 07/29/21, 14:57

  22. Christian Kuhn voted on patch set 9 V +2 CR +2 07/29/21, 15:48

  23. Christian Kuhn merged patch set 10 07/29/21, 15:48