70118[TASK] Add frontend tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Frontend/ContentElementsCest.php2new+292 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Frontend/FormFrameworkCest.phpnew+95 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Frontend/FrontendLoginCest.phpnew+82 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Frontend/IndexedSearchCest.phpnew+96 −0
- typo3/sysext/core/Tests/Acceptance/Backend/IndexedSearch/IndexedSearchModuleCest.php+4 −2
- typo3/sysext/core/Tests/Acceptance/Backend/PageTree/KeyboardAccess/SelectPagetreeWithKeyboardCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/Site/SiteModuleCest.php+26 −3
- typo3/sysext/core/Tests/Acceptance/Support/Extension/BackendCoreEnvironment.php+12 −1
- typo3/sysext/frontend/Classes/Middleware/ContentLengthResponseHeader.php+2 −2
Review log 1930
Show 35 earlier messages
-
Jochen Roth uploaded patch set 1 07/27/21, 16:29
-
Jochen Roth commented on patch set 1 07/27/21, 16:34
Depends on: https://github.com/TYPO3/styleguide/pull/229 -
core-ci voted on patch set 1 V -1 07/27/21, 16:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13819
-
Jochen Roth uploaded patch set 2 07/28/21, 17:36
-
core-ci voted on patch set 2 V -1 07/28/21, 17:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13855
-
Jochen Roth uploaded patch set 3 07/28/21, 17:40
-
core-ci voted on patch set 3 V -1 07/28/21, 17:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13856
-
Jochen Roth uploaded patch set 4 08/02/21, 11:44
-
core-ci voted on patch set 4 V -1 08/02/21, 12:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13990
-
Jochen Roth uploaded patch set 5 08/02/21, 12:32
-
core-ci voted on patch set 5 V -1 08/02/21, 12:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13994
-
Jochen Roth uploaded patch set 6 08/02/21, 14:52
-
core-ci voted on patch set 6 V -1 08/02/21, 15:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14002
-
Jochen Roth uploaded patch set 7 08/02/21, 15:57
-
Oliver Klee updated the commit message in patch set 8 08/02/21, 16:07
-
core-ci voted on patch set 7 V -1 08/02/21, 16:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14010
-
core-ci voted on patch set 8 V -1 08/02/21, 16:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14011
-
Jochen Roth uploaded patch set 9 08/02/21, 16:28
-
core-ci voted on patch set 9 V +1 08/02/21, 16:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14012
-
Jochen Roth uploaded patch set 10 08/02/21, 17:12
-
core-ci voted on patch set 10 V +1 08/02/21, 17:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14016
-
Anja Leichsenring voted on patch set 10 V +1 CR +1 08/03/21, 17:52
-
Christian Kuhn commented on patch set 10 CR -1 08/03/21, 18:00
jochen, let's talk about the uid resolving.ContentElementsCest.php:35this is kinda ugly: we shouldn't rely on a specific page-id here. this will break as soon as for instance styleguide backend generator adds another page. maybe calll BE first, find the demo page and click 'view' on it, instead or something like that? -
Jochen Roth uploaded patch set 11 08/04/21, 13:58
-
Jochen Roth commented on patch set 11 08/04/21, 13:59
ContentElementsCest.php:35ReplyDone -
core-ci voted on patch set 11 V +1 08/04/21, 14:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14094
-
Christian Kuhn voted on patch set 11 V +1 CR +1 08/05/21, 11:30
-
Oli Bartsch voted on patch set 11 V +1 CR +1 08/05/21, 13:43
-
Christian Kuhn voted on patch set 11 V +2 CR +2 08/05/21, 15:05
-
Christian Kuhn merged patch set 12 08/05/21, 15:05