Review main Merged

70118[TASK] Add frontend tests

Jochen Roth CR +2 V +2 Hard +612 −11 updated 08/05/21, 15:05

Commit message

EXT:styleguide is capable to create
a frontend page with a single click.
Therefor, acceptance tests have been
created to test each content element
for expected classes and text.

Also PHP8 undefined array key warnings
have been fixed to get tests working
as expected.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1930

Show 35 earlier messages
  1. Jochen Roth uploaded patch set 1 07/27/21, 16:29

  2. Jochen Roth commented on patch set 1 07/27/21, 16:34

  3. core-ci voted on patch set 1 V -1 07/27/21, 16:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13819

  4. Jochen Roth uploaded patch set 2 07/28/21, 17:36

  5. core-ci voted on patch set 2 V -1 07/28/21, 17:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13855

  1. Jochen Roth uploaded patch set 3 07/28/21, 17:40

  2. core-ci voted on patch set 3 V -1 07/28/21, 17:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13856

  3. Jochen Roth uploaded patch set 4 08/02/21, 11:44

  4. core-ci voted on patch set 4 V -1 08/02/21, 12:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13990

  5. Jochen Roth uploaded patch set 5 08/02/21, 12:32

  6. core-ci voted on patch set 5 V -1 08/02/21, 12:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13994

  7. Jochen Roth uploaded patch set 6 08/02/21, 14:52

  8. core-ci voted on patch set 6 V -1 08/02/21, 15:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14002

  9. Jochen Roth uploaded patch set 7 08/02/21, 15:57

  10. Oliver Klee updated the commit message in patch set 8 08/02/21, 16:07

  11. core-ci voted on patch set 7 V -1 08/02/21, 16:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14010

  12. core-ci voted on patch set 8 V -1 08/02/21, 16:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14011

  13. Jochen Roth uploaded patch set 9 08/02/21, 16:28

  14. core-ci voted on patch set 9 V +1 08/02/21, 16:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14012

  15. Jochen Roth uploaded patch set 10 08/02/21, 17:12

  16. core-ci voted on patch set 10 V +1 08/02/21, 17:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14016

  17. Anja Leichsenring voted on patch set 10 V +1 CR +1 08/03/21, 17:52

  18. Christian Kuhn commented on patch set 10 CR -1 08/03/21, 18:00

    jochen, let's talk about the uid resolving.

    ContentElementsCest.php:35

    this is kinda ugly: we shouldn't rely on a specific page-id here. this will break as soon as for instance styleguide backend generator adds another page. maybe calll BE first, find the demo page and click 'view' on it, instead or something like that?
  19. Jochen Roth uploaded patch set 11 08/04/21, 13:58

  20. Jochen Roth commented on patch set 11 08/04/21, 13:59

    ContentElementsCest.php:35 Reply

    Done
  21. core-ci voted on patch set 11 V +1 08/04/21, 14:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14094

  22. Christian Kuhn voted on patch set 11 V +1 CR +1 08/05/21, 11:30

  23. Oli Bartsch voted on patch set 11 V +1 CR +1 08/05/21, 13:43

  24. Christian Kuhn voted on patch set 11 V +2 CR +2 08/05/21, 15:05

  25. Christian Kuhn merged patch set 12 08/05/21, 15:05