Review main Merged

70119[BUGFIX] Initialize tooltips only once

Nikita Hovratov CR +2 V +2 Easy +9 −4 updated 07/28/21, 06:50

Commit message

Due to several modules initializing tooltips, it might happen that they
are initializing the same element twice or even more times. This can be
easily avoided by using the new bootstrap Tooltip method
"getOrCreateInstance". This should fix weird behaviour, where the
tooltip did not disappear.

Also, since updating to a newer bootstrap version the fix 0005bc5 did
not work anymore. This is fixed by using the container context as
selector basis.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Nikita Hovratov uploaded patch set 1 07/27/21, 19:16

  2. core-ci voted on patch set 1 V -1 07/27/21, 19:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13822

  3. Oli Bartsch uploaded patch set 2 07/27/21, 23:01

  4. core-ci voted on patch set 2 V +1 07/27/21, 23:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13827

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 07/27/21, 23:16

  6. Benni Mack voted on patch set 2 V +2 CR +2 07/28/21, 06:44

  7. Benni Mack merged patch set 3 07/28/21, 06:44

  8. Josef Glatz commented on patch set 3 07/28/21, 06:50

    > This should fix weird behaviour, where the tooltip did not disappear. 😍 I will keep an eye on it when testing master! Thanks for the patch. I had many not disappearing tooltip especially in the page tree.