Review main Merged

70121[FEATURE] Add autocomplete attribute to PasswordViewHelper

Oli Bartsch CR +2 V +2 Normal +55 −4 updated 07/29/21, 11:18

Commit message

The PasswordViewHelper is extended for a new tag
attribute "autocomplete", which can be used to
instruct the users' password manager how to fill
the password field.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 45

  1. Oli Bartsch uploaded patch set 1 07/28/21, 09:11

  2. core-ci voted on patch set 1 V +1 07/28/21, 09:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13835

  3. Benni Mack voted on patch set 1 V +1 CR +1 07/29/21, 09:28

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 07/29/21, 10:59

  5. Christian Kuhn merged patch set 2 07/29/21, 11:18