70122[BUGFIX] Fix slug generation for non-pages records with pid=0
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Wouter Wolters +1
- Anja Leichsenring +1
- Stefan Busemann +1
- Stefan Bürk +1
- Richard Haeser +1
- Mathias Brodala +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Anja Leichsenring +1
- Stefan Busemann +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2025
-
Rudy Gnodde uploaded patch set 1 07/28/21, 10:24
-
core-ci voted on patch set 1 V +1 07/28/21, 10:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13836
-
Mathias Brodala commented on patch set 1 CR -1 07/28/21, 10:42
Can you add some tests which demonstrate the expected behavior? -
Rudy Gnodde uploaded patch set 2 07/28/21, 11:45
-
Rudy Gnodde commented on patch set 2 07/28/21, 11:47
Reply
I'm not very experienced with tests. Hope this is good enough. -
core-ci voted on patch set 2 V +1 07/28/21, 11:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13839
-
Rudy Gnodde uploaded patch set 3 07/28/21, 12:00
-
core-ci voted on patch set 3 V +1 07/28/21, 12:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13842
-
Rudy Gnodde rebased onto patch set 4 08/11/21, 14:14
-
core-ci voted on patch set 4 V +1 08/11/21, 14:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14602
-
Stefan Busemann commented on patch set 4 V +1 CR +1 08/13/21, 12:37
I tested it successful with a slug field for a be user: defined('TYPO3') or die(); call_user_func(function () { $additionalColumns = [ 'slug' => [ 'exclude' => 1, 'label' => 'slug_1', 'description' => 'field description', 'config' => [ 'type' => 'slug', 'generatorOptions' => [ 'fields' => ['username'], 'fieldSeparator' => '/', 'replacements' => [ '/' => '', ], ], 'fallbackCharacter' => '-', 'eval' => 'uniqueInSite', 'default' => '' ], ], ]; \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addTCAcolumns('be_users', $additionalColumns); \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addFieldsToAllPalettesOfField('be_users', 'username', 'slug'); }); -
Wouter Wolters voted on patch set 4 CR +1 08/13/21, 13:17
-
Mathias Brodala voted on patch set 4 CR +1 08/13/21, 13:20
-
Stefan Bürk commented on patch set 4 V +1 CR +1 08/14/21, 08:45
Verified test failing without fix / not failing with fix, verifed / teste manually with be_user slugfield test noted by Stefan Busemann and with a dummy extension in a running instance with php7.4. -
Anja Leichsenring rebased onto patch set 5 08/23/21, 16:07
-
core-ci voted on patch set 5 V +1 08/23/21, 16:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15420
-
Stefan Bürk commented on patch set 5 V +1 CR +1 08/23/21, 16:32
Verified test failing without fix/ not failing with it (7.4 + 8.0 unit tests) Run functional tests (7.4). Manually verified in instance with php7.4 using descripted way by Stefan Busemann -
Wouter Wolters voted on patch set 5 CR +1 08/23/21, 16:48
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 08/23/21, 17:19
-
Mathias Brodala voted on patch set 5 CR +1 08/24/21, 06:46
-
Stefan Busemann commented on patch set 5 V +1 CR +1 08/25/21, 18:01
I added a slug field for be_users and it works as described -
Richard Haeser voted on patch set 5 CR +1 09/08/21, 09:47
-
Benjamin Franzke voted on patch set 5 V +2 CR +2 09/17/21, 04:34
-
Benjamin Franzke merged patch set 6 09/17/21, 04:34
-
Benni Mack commented on patch set 6 11/15/21, 13:47
Looks like this change introduced a regression https://forge.typo3.org/issues/95485