Review main Abandoned

70123[TASK] Show overridden values in installation-wide options

Nikita Hovratov CR 0 V 0 Easy +6 −3 updated 11/04/21, 16:53

Commit message

In addition to the warning, that a different value is used, show the
actual value in the alert box. This makes it possible to debug the
actual value without the use of the additional system extension
lowlevel.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 56

  1. Nikita Hovratov uploaded patch set 1 07/28/21, 14:43

  2. Oli Bartsch commented on patch set 1 V -1 07/28/21, 14:51

    I don't think it's a good idea to expose credentials, set in AdditionalConfiguration, in cleartext now.
  3. core-ci voted on patch set 1 V +1 07/28/21, 14:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13847

  4. Nikita Hovratov commented on patch set 1 07/28/21, 14:59

    Reply

    good point. Maybe do something like in: typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/GlobalVariableProvider.php
  5. Christian Kuhn commented on patch set 1 11/04/21, 16:43

    Any progress here, Nikita? Should we take care of Olivers hint or abandon the patch for now?
  6. Nikita Hovratov abandoned the change 11/04/21, 16:53

    This needs more thoughts about security wise. Can be maybe revived in v12 development.