70125[TASK] Doctrine DBAL: Use fetchAssociative() instead of fetch()
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 144
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php+2 −2
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+1 −1
- typo3/sysext/backend/Classes/Backend/ToolbarItems/UserToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Page/LocalizationController.php+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+3 −3
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+3 −3
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+1 −1
- typo3/sysext/backend/Classes/Domain/Repository/Localization/LocalizationRepository.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractDatabaseRecordProvider.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+1 −1
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+1 −1
- typo3/sysext/backend/Classes/History/RecordHistory.php+2 −2
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+1 −1
- typo3/sysext/backend/Classes/Security/CategoryPermissionsAspect.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+2 −2
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+9 −9
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php+1 −1
Show 124 more files
- typo3/sysext/backend/Classes/View/BackendLayout/DefaultDataProvider.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutContext.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+4 −4
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+8 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractAuthenticationService.php+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+2 −2
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Authentication/GroupResolver.php+2 −2
- typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php+1 −1
- typo3/sysext/core/Classes/Category/Collection/CategoryCollection.php+2 −2
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php+1 −1
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+1 −1
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php1+3 −1
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+1 −1
- typo3/sysext/core/Classes/Database/QueryGenerator.php+3 −3
- typo3/sysext/core/Classes/Database/QueryView.php+5 −5
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+5 −5
- typo3/sysext/core/Classes/Database/RelationHandler.php+8 −8
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+27 −27
- typo3/sysext/core/Classes/DataHandling/PlainDataResolver.php+3 −3
- typo3/sysext/core/Classes/DataHandling/ReferenceIndexUpdater.php+1 −1
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+14 −14
- typo3/sysext/core/Classes/Resource/Collection/CategoryBasedFileCollection.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+4 −4
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/Search/FileSearchQuery.php+4 −1
- typo3/sysext/core/Classes/Resource/AbstractRepository.php+2 −2
- typo3/sysext/core/Classes/Resource/FileCollectionRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/FileRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php+4 −4
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+2 −2
- typo3/sysext/core/Classes/Resource/StorageRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/SynchronizeFolderRelations.php+2 −2
- typo3/sysext/core/Classes/Routing/Aspect/PersistedAliasMapper.php+1 −1
- typo3/sysext/core/Classes/Routing/Aspect/PersistedPatternMapper.php+1 −1
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php+2 −2
- typo3/sysext/core/Classes/Session/Backend/DatabaseSessionBackend.php+1 −1
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+2 −2
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −2
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+2 −2
- typo3/sysext/core/Classes/Registry.php+1 −1
- typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Log/Writer/DatabaseWriterTest.php+1 −1
- typo3/sysext/core/Tests/Functional/RegistryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Resource/Repository/AbstractRepositoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/DatabaseTreeDataProviderTest.php+1 −1
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/AddTest.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+20 −20
- typo3/sysext/extensionmanager/Classes/Domain/Repository/BulkExtensionRepositoryWriter.php+1 −1
- typo3/sysext/felogin/Classes/Domain/Repository/FrontendUserRepository.php+1 −1
- typo3/sysext/felogin/Classes/Updates/MigrateFeloginPlugins.php+1 −1
- typo3/sysext/felogin/Tests/Functional/Domain/Repository/FrontendUserRepositoryTest.php+1 −1
- typo3/sysext/frontend/Classes/Category/Collection/CategoryCollection.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+4 −4
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+4 −4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+3 −3
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+2 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+3 −3
- typo3/sysext/impexp/Classes/Controller/ExportController.php+2 −2
- typo3/sysext/impexp/Classes/Domain/Repository/PresetRepository.php+2 −2
- typo3/sysext/impexp/Classes/Import.php+2 −2
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+2 −2
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+3 −3
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+12 −12
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+6 −6
- typo3/sysext/indexed_search/Classes/Indexer.php+4 −4
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+1 −1
- typo3/sysext/info/Classes/Controller/PageInformationController.php+2 −2
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+2 −2
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/MySql.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/PostgreSql.php1+4 −5
- typo3/sysext/install/Classes/Updates/RowUpdater/WorkspaceNewPlaceholderRemovalMigration.php+1 −1
- typo3/sysext/install/Classes/Updates/DatabaseRowsUpdateWizard.php+2 −2
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+2 −2
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php+1 −1
- typo3/sysext/linkvalidator/Classes/Repository/PagesRepository.php+3 −3
- typo3/sysext/linkvalidator/Classes/Result/LinkAnalyzerResult.php+1 −1
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php+3 −3
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/FilesWithMultipleReferencesCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/ListSysLogCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/MissingFilesCommand.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php+3 −3
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+7 −10
- typo3/sysext/lowlevel/Classes/Integrity/DatabaseIntegrityCheck.php+5 −5
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+4 −4
- typo3/sysext/recordlist/Classes/RecordList/DownloadRecordList.php+1 −1
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+2 −2
- typo3/sysext/recycler/Classes/Utility/RecyclerUtility.php+1 −1
- typo3/sysext/redirects/Classes/Service/IntegrityService.php+2 −2
- typo3/sysext/redirects/Classes/Service/RedirectCacheService.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −1
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+3 −3
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationTask.php+1 −1
- typo3/sysext/scheduler/Classes/Scheduler.php+4 −4
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+1 −1
- typo3/sysext/workspaces/Classes/Command/AutoPublishCommand.php+1 −1
- typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php+4 −4
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+1 −1
- typo3/sysext/workspaces/Classes/Dependency/ElementEntity.php+3 −3
- typo3/sysext/workspaces/Classes/Domain/Record/AbstractRecord.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Record/WorkspaceRecord.php+1 −1
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+5 −5
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+1 −1
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+1 −1
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+6 −6
Review log 710
-
Benni Mack uploaded patch set 1 07/28/21, 18:46
-
core-ci voted on patch set 1 V -1 07/28/21, 18:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13858
-
Benni Mack uploaded patch set 2 07/28/21, 19:11
-
Benni Mack updated the commit message in patch set 3 07/29/21, 08:06
-
core-ci voted on patch set 3 V +1 07/29/21, 08:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13865
-
Christian Kuhn updated the commit message in patch set 4 07/29/21, 10:32
-
core-ci voted on patch set 4 V +1 07/29/21, 10:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13868
-
Christian Kuhn commented on patch set 4 V +1 CR +1 07/29/21, 10:53
PostgreSql.php:168nice drive-by. -
Oli Bartsch voted on patch set 4 V +2 CR +2 07/29/21, 10:54
-
Oli Bartsch merged patch set 5 07/29/21, 10:54
QueryBuilder.php:209