Review main Merged

70125[TASK] Doctrine DBAL: Use fetchAssociative() instead of fetch()

Benni Mack CR +2 V +2 Hard +365 −364 updated 07/29/21, 10:54

Commit message

This change migrates $result->fetch() methods
to $result->fetchAssociative() and $result->closeCursor()
to $result->free() methods.

Since TYPO3 uses fetchMode "associative" by default when
setting up the connections, this change is another
step towards Doctrine DBAL 3.0 compatibility.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 144

Show 124 more files

Review log 710

  1. Benni Mack uploaded patch set 1 07/28/21, 18:46

  2. core-ci voted on patch set 1 V -1 07/28/21, 18:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13858

  3. Benni Mack uploaded patch set 2 07/28/21, 19:11

  4. Benni Mack updated the commit message in patch set 3 07/29/21, 08:06

  5. core-ci voted on patch set 3 V +1 07/29/21, 08:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13865

  6. Christian Kuhn updated the commit message in patch set 4 07/29/21, 10:32

  7. core-ci voted on patch set 4 V +1 07/29/21, 10:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13868

  8. Christian Kuhn commented on patch set 4 V +1 CR +1 07/29/21, 10:53

    QueryBuilder.php:209

    special thanks for this one, styleguide phpstan just stumbled upon that yesterday.

    PostgreSql.php:168

    nice drive-by.
  9. Oli Bartsch voted on patch set 4 V +2 CR +2 07/29/21, 10:54

  10. Oli Bartsch merged patch set 5 07/29/21, 10:54