70128[BUGFIX] Fix page link in redirects module pagination
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1723
-
Martin Tepper uploaded patch set 1 07/29/21, 12:37
-
core-ci voted on patch set 1 V -1 07/29/21, 12:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13879
-
Martin Tepper uploaded patch set 2 07/29/21, 13:40
-
core-ci voted on patch set 2 V +1 07/29/21, 14:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13881
-
Oli Bartsch commented on patch set 2 V -1 08/02/21, 10:03
With this patch applied, the backend is still loaded "nested" in the content frame. I think - without testing - the problem could be the "self.location.href = url;" in processNavigate(). Could you have a look if this might fix it? Also, please always describe what's fixed in the commit message, not what wasn't working before. For more details, see: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#summary-line-first-line -
Martin Tepper commented on patch set 2 08/02/21, 10:55
Reply
Hello Oliver, i'd checked the patch again and it works on a fresh system. i'd checked in different browsers too (Firefox, Chrome, Edge). Can you please check again? Thanks for you comment -
Martin Tepper updated the commit message in patch set 3 08/02/21, 11:23
-
core-ci voted on patch set 3 V +1 08/02/21, 12:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13986
-
Martin Tepper commented on patch set 3 08/02/21, 12:29
Reply
"I think - without testing - the problem could be the "self.location.href = url;" in processNavigate(). Could you have a look if this might fix it?" The line "self.location.href = url;" was not executed because the condition of target variable was not successfull. the value was null. -
Martin Tepper commented on patch set 3 08/02/21, 12:41
I made additional checks and verified the patch is working with a plain TYPO3 10.4.28 and 11.4.0 installation. -
Oli Bartsch commented on patch set 3 08/02/21, 23:10
Reply
Unfortunately it's still not working for me. So let's wait for others to test. Besides that, could you please have a look at my other comment regarding the commit message. > Also, please always describe what's fixed in the commit message, not what wasn't working before. For more details, see: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#summary-line-first-line -
Martin Tepper updated the commit message in patch set 4 08/03/21, 05:45
-
core-ci voted on patch set 4 V +1 08/03/21, 06:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14031
-
Jigal van Hemert commented on patch set 4 V +1 CR +1 10/13/21, 06:47
Tested on 10.4 where we found the same issue. Works fine now in redirects module. -
Nikita Hovratov rebased onto patch set 5 10/13/21, 07:43
-
core-ci voted on patch set 5 V +1 10/13/21, 08:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18014
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 10/13/21, 08:15
-
Oli Bartsch updated the commit message in patch set 6 10/13/21, 14:07
-
Nikita Hovratov voted on patch set 6 V +1 CR +1 10/13/21, 14:09
-
core-ci voted on patch set 6 V +1 10/13/21, 14:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18048
-
Benni Mack voted on patch set 6 V +2 CR +2 10/13/21, 14:29
-
Benni Mack merged patch set 7 10/13/21, 14:29