Review main Merged

70128[BUGFIX] Fix page link in redirects module pagination

Martin Tepper CR +2 V +2 Easy +5 −3 updated 10/13/21, 14:29

Commit message

With this patch, the page link (requesting a
dedicated paginated page) in the redirects module
pagination is now working again. This is done
by accessing the target from the corresponding
event, since it's not forwarded as method
argument.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1723

  1. Martin Tepper uploaded patch set 1 07/29/21, 12:37

  2. core-ci voted on patch set 1 V -1 07/29/21, 12:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13879

  3. Martin Tepper uploaded patch set 2 07/29/21, 13:40

  4. core-ci voted on patch set 2 V +1 07/29/21, 14:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13881

  5. Oli Bartsch commented on patch set 2 V -1 08/02/21, 10:03

    With this patch applied, the backend is still loaded "nested" in the content frame. I think - without testing - the problem could be the "self.location.href = url;" in processNavigate(). Could you have a look if this might fix it? Also, please always describe what's fixed in the commit message, not what wasn't working before. For more details, see: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#summary-line-first-line
  6. Martin Tepper commented on patch set 2 08/02/21, 10:55

    Reply

    Hello Oliver, i'd checked the patch again and it works on a fresh system. i'd checked in different browsers too (Firefox, Chrome, Edge). Can you please check again? Thanks for you comment
  7. Martin Tepper updated the commit message in patch set 3 08/02/21, 11:23

  8. core-ci voted on patch set 3 V +1 08/02/21, 12:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13986

  9. Martin Tepper commented on patch set 3 08/02/21, 12:29

    Reply

    "I think - without testing - the problem could be the "self.location.href = url;" in processNavigate(). Could you have a look if this might fix it?" The line "self.location.href = url;" was not executed because the condition of target variable was not successfull. the value was null.
  10. Martin Tepper commented on patch set 3 08/02/21, 12:41

    I made additional checks and verified the patch is working with a plain TYPO3 10.4.28 and 11.4.0 installation.
  11. Oli Bartsch commented on patch set 3 08/02/21, 23:10

    Reply

    Unfortunately it's still not working for me. So let's wait for others to test. Besides that, could you please have a look at my other comment regarding the commit message. > Also, please always describe what's fixed in the commit message, not what wasn't working before. For more details, see: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#summary-line-first-line
  12. Martin Tepper updated the commit message in patch set 4 08/03/21, 05:45

  13. core-ci voted on patch set 4 V +1 08/03/21, 06:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14031

  14. Jigal van Hemert commented on patch set 4 V +1 CR +1 10/13/21, 06:47

    Tested on 10.4 where we found the same issue. Works fine now in redirects module.
  15. Nikita Hovratov rebased onto patch set 5 10/13/21, 07:43

  16. core-ci voted on patch set 5 V +1 10/13/21, 08:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18014

  17. Nikita Hovratov voted on patch set 5 V +1 CR +1 10/13/21, 08:15

  18. Oli Bartsch updated the commit message in patch set 6 10/13/21, 14:07

  19. Oli Bartsch commented on patch set 6 V +1 CR +1 10/13/21, 14:08

    Reply

    Done

    Reply

    Done
  20. Nikita Hovratov voted on patch set 6 V +1 CR +1 10/13/21, 14:09

  21. core-ci voted on patch set 6 V +1 10/13/21, 14:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18048

  22. Benni Mack voted on patch set 6 V +2 CR +2 10/13/21, 14:29

  23. Benni Mack merged patch set 7 10/13/21, 14:29