Review main Merged

70130[TASK] Deprecate wincache cache backend

Christian Kuhn CR +2 V +2 Normal +77 −1 updated 07/30/21, 13:26

Commit message

The upstream wincache PHP module is unmaintained, a
PHP 7.4 version came late and there is no work for
a PHP 8 compatible version on the horizon.

The ApcuBackend is a suitable alternative that works
on windows platform as ram driven key/value store.

The patch deprecates the wincache based cache
backend implementation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 78

  1. Christian Kuhn uploaded patch set 1 07/29/21, 15:19

  2. core-ci voted on patch set 1 V +1 07/29/21, 15:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13884

  3. Jochen Roth voted on patch set 1 V +1 CR +1 07/30/21, 07:56

  4. Georg Ringer commented on patch set 1 07/30/21, 08:53

    should we add an exception if php8 is used?
  5. Benni Mack commented on patch set 1 V +1 CR +1 07/30/21, 11:46

    Reply

    wouldn't do this, as there might be a PHP8 compatible fork people might use as a PHP extension (I've seen people do such things in Windows-compat solutions), where this would mean they'd need to do an extra hack. Actually, we should have stopped shipping this Cache BE years ago.
  6. Christian Kuhn commented on patch set 1 07/30/21, 13:26

    Reply

    Agreed. There is no direct need to block php8 here. Assuming the module isn't loaded, the exception would kick in.
  7. Christian Kuhn voted on patch set 1 V +2 CR +2 07/30/21, 13:26

  8. Christian Kuhn merged patch set 2 07/30/21, 13:26