Review 10.4 Merged

70131[BUGFIX] Add typehints for Doctrine DBAL 2.13.x

Benni Mack CR +2 V +2 Easy +2 −3 updated 07/29/21, 19:02

Commit message

In order to have developers use the new API
in their IDEs, the type hints for QueryBuilder->execute()
and Connection->select() are adapted to also
use the API calls as in TYPO3 v11 / Doctrine 2.13.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack uploaded patch set 1 07/29/21, 15:49

  2. core-ci voted on patch set 1 V +1 07/29/21, 15:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13889

  3. Oli Bartsch voted on patch set 1 CR +1 07/29/21, 16:21

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 07/29/21, 19:02

  5. Christian Kuhn merged patch set 2 07/29/21, 19:02