Review main Merged

70152[FEATURE] Add "notInSet" to Doctrine DBAL ExpressionBuilder

Benni Mack CR +2 V +2 Hard +625 −2 updated 08/04/21, 10:48

Commit message

The "inSet" method is very useful for finding CSV
values in fields, however there was never a "notInSet"
method which is now available for TYPO3 Core.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 812

  1. Benni Mack uploaded patch set 1 07/29/21, 15:55

  2. core-ci voted on patch set 1 V +1 07/29/21, 16:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13892

  3. Benni Mack uploaded patch set 2 07/30/21, 09:57

  4. core-ci voted on patch set 2 V -1 07/30/21, 10:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13919

  5. Benni Mack uploaded patch set 3 08/02/21, 10:04

  6. core-ci voted on patch set 3 V +1 08/02/21, 10:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13981

  7. Benni Mack uploaded patch set 4 08/02/21, 11:23

  8. core-ci voted on patch set 4 V +1 08/02/21, 12:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13987

  9. Georg Ringer voted on patch set 4 V +1 CR +1 08/02/21, 17:54

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 08/04/21, 09:11

  11. Benni Mack voted on patch set 4 V +2 CR +2 08/04/21, 10:48

  12. Benni Mack merged patch set 5 08/04/21, 10:48