Review main Merged

70159[TASK] Change indent for .rst in .editorconfig

Simon Gilli CR +2 V +2 Easy +1 −1 updated 07/29/21, 21:30

Commit message

For the covenience when creating files with code snippets
the indent of .rst is changed to 4 spaces. This works for
all cases also for lists where normally 3 spaces are used.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Simon Gilli uploaded patch set 1 07/29/21, 20:55

  2. Christian Kuhn updated the commit message in patch set 2 07/29/21, 21:01

  3. Christian Kuhn commented on patch set 2 V +2 CR +2 07/29/21, 21:02

    Yes! The 3 space indenting is incredibly annoying when copy+pasting for instance php snippets.
  4. Oli Bartsch voted on patch set 2 V +1 CR +1 07/29/21, 21:09

  5. core-ci voted on patch set 1 V +1 07/29/21, 21:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13905

  6. core-ci voted on patch set 2 V +1 07/29/21, 21:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13906

  7. Christian Kuhn merged patch set 3 07/29/21, 21:30