70162[FEATURE] Improve the 'records overview' wizard for group elements
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 46
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/FieldWizard/RecordOverview.ts5new+268 −0
- Build/types/TYPO3/index.d.ts+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/RecordOverviewController.php1new+204 −0
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php1+2 −0
- typo3/sysext/backend/Classes/Form/FieldWizard/RecordsOverview.php1+72 −61
- typo3/sysext/backend/Classes/Preview/RecordOverview/Configuration/Appearance.php1new+30 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/Configuration/PreviewText.php1new+55 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/Configuration/PreviewTextCollection.php1new+66 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/Configuration/RecordOverviewConfigurationResolver.php1new+221 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/Configuration/RecordType.php1new+176 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/Configuration/RecordTypeFactory.php2new+244 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/Event/AfterActiveStateResolvedEvent.php1new+51 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/Event/AfterPreviewImageResolvedEvent.php1new+52 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/Event/AfterPreviewTextResolvedEvent.phpnew+50 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/Record.php1new+681 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/RecordCollection.php1new+56 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/RecordOverviewRenderer.php1new+62 −0
- typo3/sysext/backend/Classes/Preview/RecordOverview/RenderingContext.php1new+52 −0
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+33 −17
- typo3/sysext/backend/Classes/ViewHelpers/Record/HumanReadableValueViewHelper.php1new+99 −0
Show 26 more files
- typo3/sysext/backend/Classes/ViewHelpers/Record/LabelViewHelper.php1new+100 −0
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php1+6 −0
- typo3/sysext/backend/Resources/Private/Language/Preview/locallang_recordoverview.xlfnew+56 −0
- typo3/sysext/backend/Resources/Private/Templates/Preview/RecordOverview/Cards.html2new+153 −0
- typo3/sysext/backend/Resources/Private/Templates/Preview/RecordOverview/Rows.htmlnew+147 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/FieldWizard/RecordOverview.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js+11 −4
- typo3/sysext/backend/Tests/Unit/Preview/RecordOverview/Configuration/RecordOverviewConfigurationResolverTest.phpnew+482 −0
- typo3/sysext/backend/Tests/Unit/Preview/RecordOverview/Configuration/RecordTypeFactoryTest.phpnew+452 −0
- typo3/sysext/backend/Tests/Unit/Preview/RecordOverview/RecordTest.phpnew+635 −0
- typo3/sysext/core/Configuration/TCA/be_groups.php+6 −0
- typo3/sysext/core/Configuration/TCA/be_users.php2+8 −0
- typo3/sysext/core/Configuration/TCA/pages.php+73 −8
- typo3/sysext/core/Configuration/TCA/sys_filemounts.php+7 −0
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+22 −3
- typo3/sysext/core/Configuration/TCA/sys_language.php+5 −0
- typo3/sysext/core/Configuration/TCA/sys_news.php+5 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-94675-ImproveRecordsOverviewWizardForGroupElements.rstnew+373 −0
- typo3/sysext/frontend/Configuration/TCA/backend_layout.php+3 −0
- typo3/sysext/frontend/Configuration/TCA/fe_groups.php+6 −0
- typo3/sysext/frontend/Configuration/TCA/fe_users.php+7 −0
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+165 −4
- typo3/sysext/indexed_search/Configuration/TCA/index_config.php+6 −0
- typo3/sysext/redirects/Configuration/TCA/sys_redirect.php+6 −0
- typo3/sysext/sys_note/Configuration/TCA/sys_note.php+6 −0
- typo3/sysext/workspaces/Configuration/TCA/sys_workspace.php+6 −0
Review log 2033
Show 48 earlier messages
-
waldhacker uploaded patch set 1 07/30/21, 13:15
-
waldhacker uploaded patch set 2 07/30/21, 13:16
-
core-ci voted on patch set 1 V +1 07/30/21, 13:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13923
-
core-ci voted on patch set 2 V +1 07/30/21, 13:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13924
-
waldhacker commented on patch set 3 07/30/21, 14:28
Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 07/30/21, 14:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13926
-
waldhacker uploaded patch set 4 08/05/21, 13:18
-
core-ci voted on patch set 4 V +1 08/05/21, 13:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14143
-
waldhacker updated the commit message in patch set 5 08/05/21, 13:39
-
core-ci voted on patch set 5 V +1 08/05/21, 13:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14144
-
waldhacker commented on patch set 6 08/07/21, 13:42
Published edit on patch set 5. -
core-ci voted on patch set 6 V +1 08/07/21, 13:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14243
-
waldhacker uploaded patch set 7 08/09/21, 10:11
-
core-ci voted on patch set 7 V -1 08/09/21, 10:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14320
-
waldhacker uploaded patch set 8 08/09/21, 10:29
-
core-ci voted on patch set 8 V +1 08/09/21, 10:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14321
-
waldhacker uploaded patch set 9 08/12/21, 15:56
-
core-ci voted on patch set 9 V +1 08/12/21, 16:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14798
-
waldhacker rebased onto patch set 10 08/12/21, 23:08
-
core-ci voted on patch set 10 V +1 08/12/21, 23:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14869
-
waldhacker rebased onto patch set 11 08/23/21, 18:36
-
core-ci voted on patch set 11 V +1 08/23/21, 18:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15446
-
waldhacker rebased onto patch set 12 08/25/21, 05:13
-
core-ci voted on patch set 12 V +1 08/25/21, 05:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15557
-
Benni Mack commented on patch set 12 CR -1 09/01/21, 12:22
Cards.html:6I'd rather solve this via Web Components than with Fluid to a) also have a proper API for records (=> going further headless) b) allow to switch views without fully reloading everythingbe_users.php:21two things here: a) shouldn't we move this declaration to each of the "types" section? b) why do we need to distinguish between image and text? The columns themselves know this already -
waldhacker commented on patch set 12 09/05/21, 09:04
Cards.html:6Reply UnresolvedMe too. The reason for this solution is that the plan was still to get this into v11 and it was time problematic for me to solve this all with Web Components, also because I don't have too much experience with it yet and this would have taken much longer. The idea was then to merge this first in the form as it is implemented in the patchset and then do the Web Components refactoring afterwards.be_users.php:21Reply Unresolved> a) shouldn't we move this declaration to each of the "types" section? You ask if these recordOverview definitions should always be in the "types" section in general? > The columns themselves know this already You suggest to determine the scope "text" or "image" in the `RecordOverviewConfigurationResolver` based on the TCA configuration? Something like if "'type' === 'inline' and 'foreign_table' === 'sys_file_reference'" then this is an image... ? -
Oliver Hader commented on patch set 12 CR -1 09/23/21, 11:21
Not sure how to say it differently, but it seems to be (too) complicated...RecordOverview.ts:31Unresolvedbasically a `const` not an `enum`RecordOverview.ts:69Unresolvednot used/required?RecordOverview.ts:178Unresolved`me` is not required, arrow functions support local scopeRecordOverview.ts:209UnresolvedHm... this whole function... not sure...RecordOverview.ts:225UnresolvedThat's just `data.content` then, isn't it? Why use html`` here?RecordOverviewController.php:58UnresolvedProbably should be explicit, since it's the only "public" action... Either GET or POST should be enforced...GroupElement.php:246UnresolvedWhy is this required. In case it's used for updating client state, existing process-flow of FormEngine should be used (and corresponding events).RecordsOverview.php:114UnresolvedAs mentioned already earlier: This should be a web component. Besides that, it breaks back-ward compatibility - I'm not sure if that is relevant here...Appearance.php:25UnresolvedNot sure about this whole class...PreviewText.php:21UnresolvedDoes it "define" the preview text or just hold data (which one then, pre-processed or raw-data) in terms of a DTO?PreviewTextCollection.php:23UnresolvedNot sure about this class in general... what's the benefit instead of using an array?RecordOverviewConfigurationResolver.php:162UnresolvedIn case I understood it correctly, the differences are just the types... FileInterface-object vs. scalar data (should be "scalar" then instead of "text")...RecordType.php:30UnresolvedNot sure about this class.... what does it do, why is it useful?RecordTypeFactory.php:166UnresolvedI think it could happen, that type could not be resolved, thus `?string` might be an option here...RecordTypeFactory.php:197UnresolvedWhat about `inline`? In general it the next custom implementation dealing with relations, doing it a bit different again...AfterActiveStateResolvedEvent.php:31UnresolvedWhat is "the active state of a record", what does it mean?AfterPreviewImageResolvedEvent.php:32UnresolvedProbably `$previewImage` is nullable, so that event-handlers can add a default image, right?Record.php:52UnresolvedNot sure about this class, as it is a repository, cache-manager, model, event-dispatcher and data-processor/-resolver...RecordCollection.php:25UnresolvedNot sure about this class...RecordOverviewRenderer.php:52UnresolvedI just don't know: Are paths overridable, or was that planned to be possible? In terms of customization...RenderingContext.php:33UnresolvedIs that `RecordCollection->identifier`?HumanReadableValueViewHelper.php:50UnresolvedNot sure about this view-helper...LabelViewHelper.php:53UnresolvedNot sure about this view-helper...AjaxRoutes.php:83UnresolvedCurrently `action=redraw` needs to be given... thus, probably make it explicit by using `redrawAction` and drop possibility to have more actions there... -
Benni Mack wrote 11/29/21, 10:08
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 13 11/29/21, 13:19
-
core-ci voted on patch set 13 V +1 11/29/21, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19999
-
Simon Schaufelberger commented on patch set 13 04/26/22, 20:44
@Ralf, can you plase have a look at the unresolved comments? I would love to see this in v12! -
Christian Kuhn commented on patch set 13 06/11/23, 23:09
hey. this huge patch seems to be stalled since it has been pushed. it does not make much sense to keep it pending in the review chain when nothing happens here and nobody seems be pick it up again. as such, i hope it's ok to abandon here for now. -
Christian Kuhn abandoned the change 06/11/23, 23:10