Review main Abandoned

70162[FEATURE] Improve the 'records overview' wizard for group elements

waldhacker CR 0 V 0 Nightmare +5234 −98 updated 06/11/23, 23:10

Commit message

To give editors a better overview of the records referenced in
group elements (`type=group` and `internal_type=db`),
the 'recordsOverview' field wizard has been revised.
The referenced records are now displayed in the form of cards instead
of a table.
Since referenced records are sometimes created without a title, various
additional information can be displayed in the cards to give editors
a better overview .
As an alternative to the controls on the selection field, the cards can
be sorted using drag and drop and removed from the select list.

In the page module, records of the shortcut content element are also
displayed differently than before.
Similar to the 'recordsOverview' field wizard, the records are displayed
with additional information in list form.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 46

Show 26 more files

Review log 2033

Show 48 earlier messages
  1. waldhacker uploaded patch set 1 07/30/21, 13:15

  2. waldhacker uploaded patch set 2 07/30/21, 13:16

  3. core-ci voted on patch set 1 V +1 07/30/21, 13:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13923

  4. core-ci voted on patch set 2 V +1 07/30/21, 13:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13924

  5. waldhacker commented on patch set 3 07/30/21, 14:28

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 07/30/21, 14:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13926

  7. waldhacker uploaded patch set 4 08/05/21, 13:18

  8. core-ci voted on patch set 4 V +1 08/05/21, 13:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14143

  1. waldhacker updated the commit message in patch set 5 08/05/21, 13:39

  2. core-ci voted on patch set 5 V +1 08/05/21, 13:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14144

  3. waldhacker commented on patch set 6 08/07/21, 13:42

    Published edit on patch set 5.
  4. core-ci voted on patch set 6 V +1 08/07/21, 13:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14243

  5. waldhacker uploaded patch set 7 08/09/21, 10:11

  6. core-ci voted on patch set 7 V -1 08/09/21, 10:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14320

  7. waldhacker uploaded patch set 8 08/09/21, 10:29

  8. core-ci voted on patch set 8 V +1 08/09/21, 10:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14321

  9. waldhacker uploaded patch set 9 08/12/21, 15:56

  10. core-ci voted on patch set 9 V +1 08/12/21, 16:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14798

  11. waldhacker rebased onto patch set 10 08/12/21, 23:08

  12. core-ci voted on patch set 10 V +1 08/12/21, 23:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14869

  13. waldhacker rebased onto patch set 11 08/23/21, 18:36

  14. core-ci voted on patch set 11 V +1 08/23/21, 18:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15446

  15. waldhacker rebased onto patch set 12 08/25/21, 05:13

  16. core-ci voted on patch set 12 V +1 08/25/21, 05:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15557

  17. Benni Mack commented on patch set 12 CR -1 09/01/21, 12:22

    Cards.html:6

    I'd rather solve this via Web Components than with Fluid to a) also have a proper API for records (=> going further headless) b) allow to switch views without fully reloading everything

    be_users.php:21

    two things here: a) shouldn't we move this declaration to each of the "types" section? b) why do we need to distinguish between image and text? The columns themselves know this already
  18. waldhacker commented on patch set 12 09/05/21, 09:04

    Cards.html:6 Reply Unresolved

    Me too. The reason for this solution is that the plan was still to get this into v11 and it was time problematic for me to solve this all with Web Components, also because I don't have too much experience with it yet and this would have taken much longer. The idea was then to merge this first in the form as it is implemented in the patchset and then do the Web Components refactoring afterwards.

    be_users.php:21 Reply Unresolved

    > a) shouldn't we move this declaration to each of the "types" section? You ask if these recordOverview definitions should always be in the "types" section in general? > The columns themselves know this already You suggest to determine the scope "text" or "image" in the `RecordOverviewConfigurationResolver` based on the TCA configuration? Something like if "'type' === 'inline' and 'foreign_table' === 'sys_file_reference'" then this is an image... ?
  19. Oliver Hader commented on patch set 12 CR -1 09/23/21, 11:21

    Not sure how to say it differently, but it seems to be (too) complicated...

    RecordOverview.ts:31 Unresolved

    basically a `const` not an `enum`

    RecordOverview.ts:69 Unresolved

    not used/required?

    RecordOverview.ts:178 Unresolved

    `me` is not required, arrow functions support local scope

    RecordOverview.ts:209 Unresolved

    Hm... this whole function... not sure...

    RecordOverview.ts:225 Unresolved

    That's just `data.content` then, isn't it? Why use html`` here?

    RecordOverviewController.php:58 Unresolved

    Probably should be explicit, since it's the only "public" action... Either GET or POST should be enforced...

    GroupElement.php:246 Unresolved

    Why is this required. In case it's used for updating client state, existing process-flow of FormEngine should be used (and corresponding events).

    RecordsOverview.php:114 Unresolved

    As mentioned already earlier: This should be a web component. Besides that, it breaks back-ward compatibility - I'm not sure if that is relevant here...

    Appearance.php:25 Unresolved

    Not sure about this whole class...

    PreviewText.php:21 Unresolved

    Does it "define" the preview text or just hold data (which one then, pre-processed or raw-data) in terms of a DTO?

    PreviewTextCollection.php:23 Unresolved

    Not sure about this class in general... what's the benefit instead of using an array?

    RecordOverviewConfigurationResolver.php:162 Unresolved

    In case I understood it correctly, the differences are just the types... FileInterface-object vs. scalar data (should be "scalar" then instead of "text")...

    RecordType.php:30 Unresolved

    Not sure about this class.... what does it do, why is it useful?

    RecordTypeFactory.php:166 Unresolved

    I think it could happen, that type could not be resolved, thus `?string` might be an option here...

    RecordTypeFactory.php:197 Unresolved

    What about `inline`? In general it the next custom implementation dealing with relations, doing it a bit different again...

    AfterActiveStateResolvedEvent.php:31 Unresolved

    What is "the active state of a record", what does it mean?

    AfterPreviewImageResolvedEvent.php:32 Unresolved

    Probably `$previewImage` is nullable, so that event-handlers can add a default image, right?

    Record.php:52 Unresolved

    Not sure about this class, as it is a repository, cache-manager, model, event-dispatcher and data-processor/-resolver...

    RecordCollection.php:25 Unresolved

    Not sure about this class...

    RecordOverviewRenderer.php:52 Unresolved

    I just don't know: Are paths overridable, or was that planned to be possible? In terms of customization...

    RenderingContext.php:33 Unresolved

    Is that `RecordCollection->identifier`?

    HumanReadableValueViewHelper.php:50 Unresolved

    Not sure about this view-helper...

    LabelViewHelper.php:53 Unresolved

    Not sure about this view-helper...

    AjaxRoutes.php:83 Unresolved

    Currently `action=redraw` needs to be given... thus, probably make it explicit by using `redrawAction` and drop possibility to have more actions there...
  20. Benni Mack wrote 11/29/21, 10:08

    Change destination moved from master to main
  21. Benni Mack updated the commit message in patch set 13 11/29/21, 13:19

  22. core-ci voted on patch set 13 V +1 11/29/21, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19999

  23. Simon Schaufelberger commented on patch set 13 04/26/22, 20:44

    @Ralf, can you plase have a look at the unresolved comments? I would love to see this in v12!
  24. Christian Kuhn commented on patch set 13 06/11/23, 23:09

    hey. this huge patch seems to be stalled since it has been pushed. it does not make much sense to keep it pending in the review chain when nothing happens here and nobody seems be pick it up again. as such, i hope it's ok to abandon here for now.
  25. Christian Kuhn abandoned the change 06/11/23, 23:10