Review main Abandoned

70170[TASK] Streamline required argument in form viewhelpers

Torben Hansen CR 0 V 0 Easy +46 −0 updated 08/29/21, 16:54

Commit message

Adds the `required` argument to all fluid form viewhelpers
that supports the HTML5 `required` attribute.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 8

Review log 56

  1. Torben Hansen uploaded patch set 1 07/31/21, 06:05

  2. core-ci voted on patch set 1 V +1 07/31/21, 06:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13942

  3. Oli Bartsch commented on patch set 1 08/03/21, 17:33

    Hi,

    CheckboxViewHelper.php:90

    Shouldn't we use $this->registerTagAttribute() instead?
  4. Torben Hansen commented on patch set 1 08/05/21, 18:13

    CheckboxViewHelper.php:90 Reply Unresolved

    No, I do not think so, because setting `required="false"` will result in the situation, that a `required` attribute with no value will be rendered, thus the whole input field would still be considered as required.
  5. Torben Hansen commented on patch set 1 08/29/21, 16:53

    Unresolved

    DANIEL Rémy pointed out, that there is already an existing patch (with blockers) for 2 of the viewHelpers in this change - see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59027 Reading the discussion in that patch convinced me that it is better to keep things as they are and to just use additionalAttributes. I will abandon this patch for now.
  6. Torben Hansen abandoned the change 08/29/21, 16:54