70170[TASK] Streamline required argument in form viewhelpers
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 8
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php2+4 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php+5 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php+4 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadViewHelper.php+5 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/CheckboxViewHelperTest.php+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/PasswordViewHelperTest.php+10 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/RadioViewHelperTest.php+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/UploadViewHelperTest.php+10 −0
Review log 56
-
Torben Hansen uploaded patch set 1 07/31/21, 06:05
-
core-ci voted on patch set 1 V +1 07/31/21, 06:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13942
-
Oli Bartsch commented on patch set 1 08/03/21, 17:33
Hi,CheckboxViewHelper.php:90Shouldn't we use $this->registerTagAttribute() instead? -
Torben Hansen commented on patch set 1 08/05/21, 18:13
CheckboxViewHelper.php:90Reply UnresolvedNo, I do not think so, because setting `required="false"` will result in the situation, that a `required` attribute with no value will be rendered, thus the whole input field would still be considered as required. -
Torben Hansen commented on patch set 1 08/29/21, 16:53
Unresolved
DANIEL Rémy pointed out, that there is already an existing patch (with blockers) for 2 of the viewHelpers in this change - see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59027 Reading the discussion in that patch convinced me that it is better to keep things as they are and to just use additionalAttributes. I will abandon this patch for now. -
Torben Hansen abandoned the change 08/29/21, 16:54
See discussion in https://review.typo3.org/c/Packages/TYPO3.CMS/+/59027