Review main Merged

70171[BUGFIX] Remove DataHandler->newlog() functionality

Benni Mack CR +2 V +2 Normal +92 −107 updated 08/03/21, 17:25

Commit message

This change removes the internal "newlog()" method
from DataHandler. All occurrences are replaced
by DataHandler->log() methods, which newlog() acted as
a wrapper for it.

The main downside of newlog() is that the connection
to the actual record (when writing to sys_log) is lost,
and no contextual information is kept.

This change solves that problem by properly setting
the table and record uid to the log method.

The main usages for DataHandler->newlog() are
put into localization and workspaces/versionable
handling. where the "action" is currently set
to SystemLogGenericAction::UNDEFINED, because
there is no specific type for them. Specific action
types have been added for localize, versionize and
publishing.

The next step in this line of patches are:
* Clean up the labels by always using %s or {} for replacements.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1117

  1. Benni Mack uploaded patch set 1 07/31/21, 10:35

  2. core-ci voted on patch set 1 V -1 07/31/21, 10:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13945

  3. Benni Mack uploaded patch set 2 08/02/21, 08:18

  4. Benni Mack uploaded patch set 3 08/02/21, 08:36

  5. core-ci voted on patch set 2 V +1 08/02/21, 08:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13977

  6. core-ci voted on patch set 3 V -1 08/02/21, 08:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13978

  7. Benni Mack uploaded patch set 4 08/02/21, 09:07

  8. core-ci voted on patch set 4 V +1 08/02/21, 09:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13979

  9. Oli Bartsch uploaded patch set 5 08/02/21, 12:18

  10. Oli Bartsch voted on patch set 5 V +1 CR +1 08/02/21, 12:18

  11. core-ci voted on patch set 5 V +1 08/02/21, 12:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13992

  12. Jochen Roth voted on patch set 5 V +1 CR +1 08/03/21, 15:39

  13. Anja Leichsenring uploaded patch set 6 08/03/21, 16:35

  14. core-ci voted on patch set 6 V +1 08/03/21, 16:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14054

  15. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/03/21, 17:04

  16. Andreas Kienast voted on patch set 6 V +2 CR +2 08/03/21, 17:25

  17. Andreas Kienast merged patch set 7 08/03/21, 17:25