Review 10.4 Merged

70173[TASK] runTests.sh: Allow step debugging acceptance tests

Alexander Nitsche CR +2 V +2 Normal +89 −14 updated 08/08/21, 14:26

Commit message

Honor -x option for acceptance tests: Both 'Tester' and
'System under test' allow break points with -s acceptance
and -s install.

Additionally fix passing arguments to codecept during
acceptance tests of the TYPO3 installation process based
on MySQL.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Alexander Nitsche uploaded patch set 1 07/31/21, 12:52

  2. Alexander Nitsche commented on patch set 1 07/31/21, 12:57

    I have tested the patch for all acceptance test commands by ``` ./Build/Scripts/runTests.sh -s acceptance -x -e "typo3/sysext/core/Tests/Acceptance/Backend/BackendUser/CompareUserCest.php" ./Build/Scripts/runTests.sh -s acceptance -d postgres -x -e "typo3/sysext/core/Tests/Acceptance/Backend/BackendUser/CompareUserCest.php" ./Build/Scripts/runTests.sh -s install -x -e "typo3/sysext/core/Tests/Acceptance/Install/Mysql/BlankPageCest.php" ./Build/Scripts/runTests.sh -s install -d postgres -x -e "typo3/sysext/core/Tests/Acceptance/Install/Postgresql/BlankPageCest.php" ./Build/Scripts/runTests.sh -s install -d mysql -x -e "typo3/sysext/core/Tests/Acceptance/Install/Mysql/BlankPageCest.php" ``` which stopped at the first break point in the according file reliably.
  3. core-ci voted on patch set 1 V +1 07/31/21, 13:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13947

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 08/08/21, 14:26

  5. Christian Kuhn merged patch set 2 08/08/21, 14:26