Review main Merged

70175[BUGFIX] Clean up DataHandler unit tests

Nikita Hovratov CR +2 V +2 Easy +22 −14 updated 08/02/21, 06:33

Commit message

This fixes wrong input configuration, wrong method calls and adds
some missing test cases.

- The first parameter of assertSame expects the expected value. All
occurrences in DataHandlerTest, which had them mixed up, are corrected.

- TCA configuration "type => input" corrected.

- Missing test cases with empty string as input added.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Nikita Hovratov uploaded patch set 1 08/01/21, 10:42

  2. core-ci voted on patch set 1 V +1 08/01/21, 11:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13956

  3. Nikita Hovratov uploaded patch set 2 08/01/21, 11:09

  4. core-ci voted on patch set 2 V +1 08/01/21, 11:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13958

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 08/01/21, 19:50

  6. Benni Mack voted on patch set 2 V +2 CR +2 08/02/21, 06:33

  7. Benni Mack merged patch set 3 08/02/21, 06:33