70176[TASK] Deprecate GeneralUtility::shortMD5()
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 20
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php1+2 −2
- typo3/sysext/backend/Classes/Form/Container/FlexFormTabsContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/TabsContainer.php+1 −2
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/ApcuBackend.php+1 −2
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php1+2 −2
- typo3/sysext/core/Classes/Hooks/BackendUserPasswordCheck.php+1 −1
- typo3/sysext/core/Classes/Hooks/CreateSiteConfiguration.php2+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+2 −2
- typo3/sysext/core/Classes/Resource/Processing/AbstractTask.php1+1 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php2+4 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94684-GeneralUtilityShortMD5.rst1new+44 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/SlugHelperUniqueTest.php+3 −6
- typo3/sysext/core/Tests/Unit/DataHandling/SlugHelperTest.php+6 −6
- typo3/sysext/core/ext_tables.sql+1 −1
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php+1 −1
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+1 −1
Review log 1927
Show 12 earlier messages
-
Andreas Kienast uploaded patch set 1 08/01/21, 13:49
-
core-ci voted on patch set 1 V -1 08/01/21, 14:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13963
-
Andreas Kienast uploaded patch set 2 08/01/21, 14:21
-
core-ci voted on patch set 2 V +1 08/01/21, 14:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13964
-
Andreas Kienast uploaded patch set 3 08/01/21, 19:48
-
core-ci voted on patch set 3 V +1 08/01/21, 19:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13968
-
Oli Bartsch commented on patch set 3 08/02/21, 13:30
CreateSiteConfiguration.php:79Is there any reason to create a hash of the pageId as this should already be unique? Especially in case this is not unique the md5 will anyways be the same. Also UX is affected here.GeneralUtility.php:2346This should also be replaced. -
Andreas Kienast commented on patch set 3 08/02/21, 13:42
CreateSiteConfiguration.php:79Reply UnresolvedGood point, I'll think about that again. I cannot remember why the shortMD5() was introduced in the first place.GeneralUtility.php:2346Reply UnresolvedGood catch! -
Andreas Kienast uploaded patch set 4 08/02/21, 14:29
-
core-ci voted on patch set 4 V +1 08/02/21, 14:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14000
-
Georg Ringer commented on patch set 4 V +1 CR +1 08/02/21, 17:52
Deprecation-94684-GeneralUtilityShortMD5.rst:39UnresolvedI would also give this additional possbility, just because we can be nice ;) ... or use :php:`substr(md5($string), 0, 10)` to reduce the size, -
Andreas Kienast uploaded patch set 5 08/03/21, 06:09
-
core-ci voted on patch set 5 V +1 08/03/21, 06:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14032
-
Wouter Wolters voted on patch set 5 CR +1 08/03/21, 20:00
-
Jörg Bösche voted on patch set 5 CR +1 08/06/21, 07:38
-
Andreas Kienast uploaded patch set 6 08/10/21, 07:03
-
core-ci voted on patch set 6 V -1 08/10/21, 07:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14431
-
Andreas Kienast uploaded patch set 7 08/10/21, 07:34
-
core-ci voted on patch set 7 V +1 08/10/21, 07:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14437
-
Oli Bartsch commented on patch set 7 V +1 CR +1 08/10/21, 08:10
Clipboard.php:532UnresolvedNot that important, but this will make the current clipboard state of users invalid. -
Andreas Kienast uploaded patch set 8 08/12/21, 09:15
-
core-ci voted on patch set 8 V +1 08/12/21, 09:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14662
-
Oli Bartsch voted on patch set 8 V +1 CR +1 08/12/21, 09:33
-
Benni Mack voted on patch set 8 V +2 CR +2 08/12/21, 09:34
-
Benni Mack merged patch set 9 08/12/21, 09:34
-
Benni Mack commented on patch set 9 08/12/21, 10:38
AbstractTask.php:105UnresolvedI think we should trim this to also contain 10 lines. One of my existing installations now broke after logging in again. -
Benni Mack commented on patch set 9 08/12/21, 10:42
SlugHelper.php:216Unresolved