Review main Merged

70182[BUGFIX] Remove loader placeholder in SvgTree if search term is empty

Nikita Hovratov CR +2 V +2 Easy +4 −1 updated 08/17/21, 12:58

Commit message

In a case, where the search term is empty (by removing the search term
manually for example) and a node is currently selected, the loader
placeholder is now removed. This is the only case, where the method
"resetFilter" is not called.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Nikita Hovratov uploaded patch set 1 08/02/21, 17:05

  2. core-ci voted on patch set 1 V +1 08/02/21, 17:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14014

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/02/21, 19:04

  4. Benni Mack uploaded patch set 2 08/13/21, 10:56

  5. Benni Mack voted on patch set 2 V +1 CR +1 08/13/21, 11:05

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 08/13/21, 11:08

  7. core-ci voted on patch set 2 V -1 08/13/21, 11:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14937

  8. core-ci commented on patch set 2 08/13/21, 11:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14937

  9. Benni Mack rebased onto patch set 3 08/14/21, 11:11

  10. Benni Mack voted on patch set 3 V +1 CR +1 08/14/21, 11:12

  11. core-ci voted on patch set 3 V +1 08/14/21, 11:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15057

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 08/17/21, 12:58

  13. Oli Bartsch merged patch set 4 08/17/21, 12:58