Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
70183[WIP][FEATURE] Log module should show last lines of FileWriters
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/83/70183/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/83/70183/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Files 6
- typo3/sysext/belog/Classes/Controller/BackendLogController.php2+60 −2
- typo3/sysext/belog/Classes/Domain/Repository/LogFileRepository.phpnew+147 −0
- typo3/sysext/belog/Configuration/Backend/Modules.php+1 −1
- typo3/sysext/belog/Resources/Private/Templates/BackendLog/List.html+1 −1
- typo3/sysext/belog/Resources/Private/Templates/BackendLog/LogReader.htmlnew+88 −0
- typo3/sysext/core/Classes/Log/Writer/FileWriter.php+1 −1
Review log 69
-
Georg Ringer uploaded patch set 1 08/02/21, 17:37
-
core-ci voted on patch set 1 V -1 08/02/21, 17:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14017
-
crell commented on patch set 1 08/02/21, 18:59
I'm not sure this is necessary. There's already a WIP patch to switch logging to Monolog, and log everything to the database by default. That will have the result of showing all log values anyway without needing to manually parse log files. cf: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70014 That should render this approach unnecessary. -
Markus Klein commented on patch set 1 08/05/21, 18:34
The feature depends on the current log config, which is subject to change with Larry's work. Maybe we should keep the work in sync here?BackendLogController.php:127Unresolvednot sure, but shouldn't that be $pos++,because we start at -2?BackendLogController.php:137UnresolvedParsing depends on the LogWriter format. We should/must somehow at least comment that adjusting the format needs changes in the writer and here. -
Benni Mack wrote 11/29/21, 10:10
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 2 11/29/21, 13:24
-
core-ci voted on patch set 2 V -1 11/29/21, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20016
-
Georg Ringer uploaded patch set 3
V -110/09/23, 17:26 -
core-ci voted on patch set 3 V -1 10/09/23, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47610