70185[BUGFIX] Fix PageTree dropping behaviour
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Jochen Roth +1
- Wouter Wolters +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1724
-
Nikita Hovratov uploaded patch set 1 08/02/21, 20:15
-
core-ci voted on patch set 1 V +1 08/02/21, 20:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14023
-
Oliver Klee commented on patch set 1 08/02/21, 22:48
-
Nikita Hovratov uploaded patch set 2 08/03/21, 06:51
-
Nikita Hovratov commented on patch set 1 08/03/21, 06:51
Debugging leftovers, whoops :)PageTreeElement.ts:668ReplyDone -
core-ci voted on patch set 2 V -1 08/03/21, 07:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14033
-
Nikita Hovratov updated the commit message in patch set 3 08/03/21, 07:51
-
core-ci voted on patch set 3 V +1 08/03/21, 08:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14036
-
Michael Schams commented on patch set 3 V -1 08/03/21, 09:16
Thanks for looking into this. I suspect that there's still something not quite right from a usability perspective. How to reproduce: create a new page "foobar". Create one or two sub-pages of this page. Now try to create a new page BELOW the page "foobar" (not inside). For this, you would close the page branch (icon: arrow down to arrow right) and drag'n drop the new page below "foobar". Even if you manage to create the new page at the right position (you only have a split second before the page branch automatically re-opens) the new page appears as a sub-page of "foobar" after saving. Let me know if you want me to record a short video to visualize the issue. -
Oliver Klee wrote 08/03/21, 09:57
Removed reviewer Oliver Klee. -
Nikita Hovratov commented on patch set 3 08/03/21, 17:20
Reply
Hi Michael, I see what you mean. Will dig deeper then! -
Nikita Hovratov uploaded patch set 4 08/03/21, 20:31
-
core-ci voted on patch set 4 V +1 08/03/21, 20:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14063
-
Nikita Hovratov uploaded patch set 5 08/05/21, 14:23
-
core-ci voted on patch set 5 V +1 08/05/21, 14:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14147
-
Nikita Hovratov uploaded patch set 6 08/05/21, 15:13
-
Nikita Hovratov uploaded patch set 7 08/05/21, 15:19
-
core-ci voted on patch set 6 V +1 08/05/21, 15:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14151
-
core-ci voted on patch set 7 V +1 08/05/21, 15:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14152
-
Jochen Roth voted on patch set 7 V +1 CR +1 08/05/21, 16:01
-
Oli Bartsch commented on patch set 7 V +1 CR +1 08/05/21, 17:04
Awesome! -
Wouter Wolters voted on patch set 7 CR +1 08/10/21, 09:11
-
Benni Mack voted on patch set 7 V +2 CR +2 08/10/21, 09:44
-
Benni Mack merged patch set 8 08/10/21, 09:44
PageTreeElement.ts:668