Review main Merged

70188[TASK] Use DependencyInjection in FileController

Benni Mack CR +2 V +2 Normal +40 −68 updated 08/03/21, 15:35

Commit message

This change registers FileController as backend
controller in Services.yaml and allows to inject
all needed dependency via constructor DI.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Benni Mack uploaded patch set 1 08/02/21, 20:33

  2. core-ci voted on patch set 1 V -1 08/02/21, 21:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14026

  3. Benni Mack uploaded patch set 2 08/03/21, 09:53

  4. core-ci voted on patch set 2 V +1 08/03/21, 10:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14039

  5. Benni Mack updated the commit message in patch set 3 08/03/21, 12:12

  6. core-ci voted on patch set 3 V +1 08/03/21, 12:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14043

  7. Jochen Roth voted on patch set 3 V +1 CR +1 08/03/21, 15:15

  8. Oli Bartsch voted on patch set 3 V +2 CR +2 08/03/21, 15:35

  9. Oli Bartsch merged patch set 4 08/03/21, 15:35