Review main Merged

70194[TASK] Highlight invalid backend layout value

Oli Bartsch CR +2 V +2 Easy +28 −4 updated 08/03/21, 17:29

Commit message

In #89700, the page information view in the info
module was extended for a new type, which displays
the layout related (backend_layout, ..) fields for the
corresponding pages.

Since there might be field values which are not longer
valid, because the referenced backend layout does not
longer exist, the new type does  now highlight such values
with the already known `INVALID VALUE ("<value>")` string.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Simon Gilli +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 08/03/21, 12:31

  2. core-ci voted on patch set 1 V +1 08/03/21, 12:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14045

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/03/21, 13:09

  4. Simon Gilli commented on patch set 1 CR +1 08/03/21, 17:12

    Thanks, will check the functionallity a little bit later...
  5. Andreas Kienast voted on patch set 1 V +2 CR +2 08/03/21, 17:29

  6. Andreas Kienast merged patch set 2 08/03/21, 17:29