Review main Merged

70197[BUGFIX] Avoid exception on upgrades from pre 11.3

Simon Gilli CR +2 V +2 Easy +6 −2 updated 08/10/21, 09:12

Commit message

This patch avoids exceptions during the upgrade from pre 11.3 versions
where the column sys_log.channel does not exist.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Simon Gilli uploaded patch set 1 08/04/21, 11:21

  2. core-ci voted on patch set 1 V +1 08/04/21, 11:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14083

  3. Jonas Eberle voted on patch set 1 CR +1 08/04/21, 11:46

  4. Christian Kuhn commented on patch set 1 CR -1 08/05/21, 11:41

    SysLogChannel.php:98

    any chance to catch a more specific exception here? for instance, we'd really want to fail if there is a connection issue, and only catch if that field does not exist. alternative: explicitly check for field existence before firing the select query? this wouldn't harm much in this scope.
  5. Simon Gilli commented on patch set 1 08/05/21, 19:11

    SysLogChannel.php:98 Reply

    Catching now the specific exception.
  6. Simon Gilli commented on patch set 2 08/05/21, 19:12

    Published edit on patch set 1.
  7. core-ci voted on patch set 2 V +1 08/05/21, 19:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14162

  8. Wouter Wolters voted on patch set 2 CR +1 08/05/21, 19:48

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 08/05/21, 20:31

  10. Jochen Roth voted on patch set 2 V +1 CR +1 08/10/21, 07:08

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 08/10/21, 09:12

  12. Oli Bartsch merged patch set 3 08/10/21, 09:12