Review main Merged

70198[TASK] Pin selenium/standalone-chrome docker image in ac tests

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 08/05/21, 11:26

Commit message

Acceptance test docker image selenium/standalone-chrome:3.141
is re-tagged upstream to latest releases.

Latest release 3.141.59-20210729 tagged as 3.141 has issues
as shown by styleguide recently. To not run into this within
core tests, the patch pins previous version 3.141.59-20210713
for now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1216

  1. Christian Kuhn uploaded patch set 1 08/04/21, 12:43

  2. Christian Kuhn updated the commit message in patch set 2 08/04/21, 12:44

  3. Stephan Großberndt updated the commit message in patch set 3 08/04/21, 12:48

  4. core-ci voted on patch set 1 V +1 08/04/21, 12:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14085

  5. core-ci voted on patch set 2 V +1 08/04/21, 13:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14086

  6. core-ci voted on patch set 3 V +1 08/04/21, 13:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14087

  7. Jochen Roth voted on patch set 3 V +1 CR +1 08/04/21, 13:07

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 08/04/21, 13:08

  9. Wouter Wolters voted on patch set 3 CR +1 08/04/21, 14:00

  10. Christian Kuhn updated the commit message in patch set 4 08/04/21, 18:27

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 08/04/21, 18:27

  12. Christian Kuhn commented on patch set 4 08/04/21, 18:27

    revotes pls: had to drop v10 backport, it uses an older selenium-chrome.
  13. core-ci voted on patch set 4 V +1 08/04/21, 18:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14105

  14. Jochen Roth voted on patch set 4 V +1 CR +1 08/04/21, 18:46

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 08/05/21, 11:26

  16. Christian Kuhn merged patch set 5 08/05/21, 11:26