Review main Merged

70202[TASK] Deprecate CategoryRegistry and API method

Oli Bartsch CR +2 V +2 Normal +153 −37 updated 08/04/21, 19:28

Commit message

In #94622 the TCA type `category` was introduced as
replacement for the CategoryRegistry.

Therefore, the CategoryRegistry as well as the API method
ExtensionManagementUtility::makeCategorizable() are now
deprecated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 11

Review log 1218

  1. Oli Bartsch uploaded patch set 1 08/04/21, 16:52

  2. Benni Mack commented on patch set 1 08/04/21, 16:57

    I think we also need a ClassName Matcher?
  3. Oli Bartsch commented on patch set 1 08/04/21, 16:59

    Reply

    CategoryRegistry is still used in core for backwards-compatibility.
  4. core-ci voted on patch set 1 V -1 08/04/21, 17:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14099

  5. Oli Bartsch uploaded patch set 2 08/04/21, 17:08

  6. core-ci voted on patch set 2 V -1 08/04/21, 17:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14101

  7. Oli Bartsch uploaded patch set 3 08/04/21, 17:42

  8. core-ci voted on patch set 3 V +1 08/04/21, 17:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14103

  9. Oli Bartsch uploaded patch set 4 08/04/21, 18:32

  10. Oli Bartsch uploaded patch set 5 08/04/21, 18:40

  11. Oli Bartsch commented on patch set 5 08/04/21, 18:42

    Reply

    Added the ClassNameMatcher. You're right, core files are not checked.
  12. core-ci voted on patch set 4 V +1 08/04/21, 18:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14106

  13. Oli Bartsch uploaded patch set 6 08/04/21, 18:46

  14. Christian Kuhn commented on patch set 6 V +1 CR +1 08/04/21, 18:50

    Reply

    can still be in ClassNameMatcher.
  15. core-ci voted on patch set 5 V +1 08/04/21, 18:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14107

  16. core-ci voted on patch set 6 V +1 08/04/21, 18:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14108

  17. Benni Mack voted on patch set 6 V +2 CR +2 08/04/21, 19:28

  18. Benni Mack merged patch set 7 08/04/21, 19:28