70202[TASK] Deprecate CategoryRegistry and API method
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 11
- typo3/sysext/core/Classes/Category/CategoryRegistry.php+7 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+8 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85613-CategoryRegistry.rstnew+56 −0
- typo3/sysext/core/Documentation/Changelog/master/Important-94697-QuoteDatabaseIdentifiersWhenUsedInsteadOfGloballyUpfront.rst+2 −2
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+0 −34
- typo3/sysext/core/Tests/UnitDeprecated/Category/CategoryRegistryTest.phprenamed+1 −1
- typo3/sysext/core/Tests/UnitDeprecated/Utility/ExtensionManagementUtilityTest.phpnew+61 −0
- typo3/sysext/install/Classes/Service/LoadTcaService.php+1 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1218
-
Oli Bartsch uploaded patch set 1 08/04/21, 16:52
-
Benni Mack commented on patch set 1 08/04/21, 16:57
I think we also need a ClassName Matcher? -
Oli Bartsch commented on patch set 1 08/04/21, 16:59
Reply
CategoryRegistry is still used in core for backwards-compatibility. -
core-ci voted on patch set 1 V -1 08/04/21, 17:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14099
-
Oli Bartsch uploaded patch set 2 08/04/21, 17:08
-
core-ci voted on patch set 2 V -1 08/04/21, 17:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14101
-
Oli Bartsch uploaded patch set 3 08/04/21, 17:42
-
core-ci voted on patch set 3 V +1 08/04/21, 17:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14103
-
Oli Bartsch uploaded patch set 4 08/04/21, 18:32
-
Oli Bartsch uploaded patch set 5 08/04/21, 18:40
-
Oli Bartsch commented on patch set 5 08/04/21, 18:42
Reply
Added the ClassNameMatcher. You're right, core files are not checked. -
core-ci voted on patch set 4 V +1 08/04/21, 18:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14106
-
Oli Bartsch uploaded patch set 6 08/04/21, 18:46
-
Christian Kuhn commented on patch set 6 V +1 CR +1 08/04/21, 18:50
Reply
can still be in ClassNameMatcher. -
core-ci voted on patch set 5 V +1 08/04/21, 18:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14107
-
core-ci voted on patch set 6 V +1 08/04/21, 18:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14108
-
Benni Mack voted on patch set 6 V +2 CR +2 08/04/21, 19:28
-
Benni Mack merged patch set 7 08/04/21, 19:28