Review main Merged

70204[TASK] Use a static closure call if possible for better scoping

Wouter Wolters CR +2 V +2 Hard +405 −404 updated 09/24/21, 10:38

Commit message

In some cases it can improve performance too.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 199

Show 179 more files

Review log 1318

  1. Wouter Wolters uploaded patch set 1 08/04/21, 18:04

  2. core-ci voted on patch set 1 V +1 08/04/21, 18:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14104

  3. crell commented on patch set 1 08/04/21, 19:49

    I'm in favor of this, with the note below about short-lambdas. However, it may be logistically easier to do in chunks (one file or extension at a time) to make review easier, and to minimize conflicts with other patches, of which there are a whole lot. I didn't review the whole thing yet, due to the aforementioned size.

    DefaultFunctionsProvider.php:84

    There's a whole lot of cases in this patch where it makes sense to swap to a short-lambda as long as we're modifying the line. This is one of many many examples.
  4. Wouter Wolters uploaded patch set 2 08/05/21, 11:29

  5. Wouter Wolters commented on patch set 2 08/05/21, 11:31

    DefaultFunctionsProvider.php:84 Reply

    short lambda will be done in a separate patch. There is a fixer available for that.
  6. core-ci voted on patch set 2 V -1 08/05/21, 11:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14133

  7. Wouter Wolters commented on patch set 2 CR -1 08/05/21, 17:16

    The problem here is that all tests that use ->will(function... can't be made static but the fixer will make it static. There is an open PR https://github.com/phpspec/prophecy/pull/534/files that fixes this problem. Hopefully that can be merged and released soon to finish this patch.
  8. Wouter Wolters uploaded patch set 3 09/12/21, 12:17

  9. core-ci voted on patch set 3 V -1 09/12/21, 12:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16618

  10. Wouter Wolters uploaded patch set 4 09/13/21, 14:53

  11. Wouter Wolters commented on patch set 4 09/13/21, 14:53

    DefaultFunctionsProvider.php:84 Reply

    Done
  12. core-ci voted on patch set 4 V +1 09/13/21, 15:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16660

  13. Wouter Wolters uploaded patch set 5 09/24/21, 09:23

  14. core-ci voted on patch set 5 V +1 09/24/21, 09:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17147

  15. Benni Mack voted on patch set 5 V +1 CR +1 09/24/21, 09:51

  16. Simon Schaufelberger voted on patch set 5 V +1 CR +1 09/24/21, 10:36

  17. Andreas Kienast voted on patch set 5 V +2 CR +2 09/24/21, 10:38

  18. Andreas Kienast merged patch set 6 09/24/21, 10:38