Review main Merged

70205[TASK] Quote field names in typoscript

Jochen Roth CR +2 V +2 Easy +15 −15 updated 10/19/21, 13:07

Commit message

Some TS snippets miss proper DB field name quoting.
This is important to get right to be as DBMS compatible
as possible.

* Make additionalWhere in xmlSitemap dataProviders
  quotable for the quote filename syntax.
* Change syntax for DatabaseQueryProcessor usages
  in TypoScript

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 3038

Show 913 earlier messages
  1. Jochen Roth uploaded patch set 1 08/04/21, 21:04

  2. core-ci voted on patch set 1 V +1 08/04/21, 21:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14110

  3. Jochen Roth uploaded patch set 2 08/05/21, 10:34

  4. core-ci voted on patch set 2 V +1 08/05/21, 10:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14131

  5. Christian Kuhn commented on patch set 2 08/05/21, 11:38

    JsonRenderer.typoscript:113

    weird indenting.

    PagesXmlSitemapDataProvider.php:92

    since the feature flag is for TCA and not typoscript, it is misused here. simply drop the if and always call QueryHelper::quoteDatabaseIdentifiers

    RecordsXmlSitemapDataProvider.php:103

    same case as the one in the other file.
  6. Christian Kuhn voted on patch set 2 CR -1 08/05/21, 11:38

  7. Jochen Roth uploaded patch set 3 08/05/21, 11:48

  8. Jochen Roth commented on patch set 3 08/05/21, 11:49

    JsonRenderer.typoscript:113 Reply

    Done

    PagesXmlSitemapDataProvider.php:92 Reply

    Done

    RecordsXmlSitemapDataProvider.php:103 Reply

    Done
  9. core-ci voted on patch set 3 V +1 08/05/21, 11:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14135

  10. Stefan Bürk commented on patch set 3 V +1 CR -1 08/14/21, 09:59

    After removing the runtimeDbQuotingOfTcaConfiguration conditions as commented/stated by Christian Kuhn, the commit description does not make sense anymore. Should it not be changed ?
  11. Christian Kuhn commented on patch set 3 08/14/21, 10:45

    Reply

    yeah. should be adapted.
  12. Jochen Roth uploaded patch set 4 08/14/21, 16:34

  13. core-ci voted on patch set 4 V +1 08/14/21, 16:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15099

  1. Stefan Bürk commented on patch set 4 08/14/21, 20:24

    Still not happy with the commit message. From my point of view it is not descriping correctly what this patch does. As far as I see it does following: - change syntax for some DatabaseQueryProcessor usages in TypoScript - Make additionalWhere in xmlSitemap dataProviders quotable for the new quotable syntax. Currently it is not really clear - "also add quoting for addionalWhere" could be missleading - or I'm wrong ? Thought about changing commit message by myself, but was not sure if I'm right - so added it as comment to be discussed.
  2. Jochen Roth uploaded patch set 5 08/16/21, 07:32

  3. Jochen Roth commented on patch set 5 08/16/21, 07:45

    Reply

    Hey, thanks for your detailed message. Changed the commit message according to your suggestions. Feel free to adjust the commit message or code if you have any improvements.
  4. core-ci voted on patch set 5 V +1 08/16/21, 07:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15145

  5. Guido Schmechel commented on patch set 5 08/16/21, 11:08

    I'm not sure at the moment, but wouldn't the RST files have to be adapted so that the syntax is correct?
  6. Benni Mack voted on patch set 5 CR +1 09/28/21, 15:11

  7. Georg Ringer voted on patch set 5 V +1 CR +1 10/05/21, 18:49

  8. Simon Schaufelberger commented on patch set 5 10/15/21, 23:20

  9. Simon Schaufelberger voted on patch set 5 CR +1 10/15/21, 23:25

  10. Simon Schaufelberger commented on patch set 5 10/15/21, 23:27

    JsonRenderer.typoscript:85

    i just see the indentation is not correct here, maybe that can be fixed as well?
  11. Jochen Roth uploaded patch set 6 10/18/21, 07:35

  12. Jochen Roth commented on patch set 6 10/18/21, 07:38

    JsonRenderer.typoscript:85 Reply

    Done
  13. core-ci voted on patch set 6 V +1 10/18/21, 07:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18275

  14. Simon Schaufelberger voted on patch set 6 CR +1 10/18/21, 23:24

  15. Christian Kuhn uploaded patch set 7 10/19/21, 12:38

  16. Christian Kuhn commented on patch set 7 10/19/21, 12:38

    that's not 'new' anymore ;)

    Reply

    Done
  17. Christian Kuhn commented on patch set 7 CR -1 10/19/21, 12:41

    still fiddling wiht details
  18. Christian Kuhn uploaded patch set 8 10/19/21, 12:45

  19. Christian Kuhn voted on patch set 8 V +1 CR +1 10/19/21, 12:45

  20. Simon Schaufelberger voted on patch set 8 V +1 CR +1 10/19/21, 12:51

  21. core-ci voted on patch set 7 V +1 10/19/21, 12:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18309

  22. Stefan Bürk voted on patch set 8 V +1 CR +1 10/19/21, 12:53

  23. core-ci voted on patch set 8 V +1 10/19/21, 12:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18310

  24. Christian Kuhn voted on patch set 8 V +2 CR +2 10/19/21, 13:07

  25. Christian Kuhn merged patch set 9 10/19/21, 13:07