Review main Merged

70206[BUGFIX] Add necessary type property to reduced data structure

Oli Bartsch CR +2 V +2 Hard +256 −37 updated 08/06/21, 13:35

Commit message

When using a SelectTree in flexform, the FormSelectTreeAjaxController
reduces the data structure array, passed to the tcaSelectTreeAjaxFieldData
FormDataGroup, down to the relevant element only.

This previously lead to deprecation messages as one of the
DataProviders, FlexPrepare, calls the TcaMigration for the
passed data structure array. This then failed for the container,
since it was falsely treated as an invalid TCA column, due to the
missing type property.

This is now fixed by adding the missing "type=array" property
to the reduced data structure.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Oli Bartsch uploaded patch set 1 08/05/21, 00:59

  2. core-ci voted on patch set 1 V -1 08/05/21, 01:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14111

  3. Oli Bartsch uploaded patch set 2 08/05/21, 16:59

  4. core-ci voted on patch set 2 V +1 08/05/21, 17:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14156

  5. Oli Bartsch updated the commit message in patch set 3 08/05/21, 17:19

  6. core-ci voted on patch set 3 V +1 08/05/21, 17:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14157

  7. Wouter Wolters voted on patch set 3 CR +1 08/05/21, 19:49

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 08/05/21, 22:44

  9. Jochen Roth voted on patch set 3 V +1 CR +1 08/06/21, 07:20

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 08/06/21, 13:35

  11. Oli Bartsch merged patch set 4 08/06/21, 13:35