Review main Merged

70207[BUGFIX] Only minifyJS once in Frontend

Benni Mack CR +2 V +2 Normal +13 −41 updated 08/05/21, 18:52

Commit message

If you have inline JS (or inlineFooterJS) code
the method "GeneralUtility::minifyJavaScript()"
is called twice for the same code to actually minify
the code, because PageRenderer takes
care of minification, so FE process does not
explicitly have to do that.

This does no harm, only if there is a hook
within minifyJavaScript(), the processing is triggered
twice. This also only happens if config.compressJs = 1
is called.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1015

  1. Benni Mack uploaded patch set 1 08/05/21, 06:34

  2. Benni Mack updated the commit message in patch set 2 08/05/21, 06:37

  3. Benni Mack updated the commit message in patch set 3 08/05/21, 06:37

  4. core-ci voted on patch set 1 V -1 08/05/21, 06:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14119

  5. core-ci voted on patch set 2 V +1 08/05/21, 06:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14120

  6. core-ci voted on patch set 3 V +1 08/05/21, 06:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14121

  7. Benni Mack uploaded patch set 4 08/05/21, 13:08

  8. Oli Bartsch voted on patch set 4 V +1 CR +1 08/05/21, 13:09

  9. Oli Bartsch uploaded patch set 5 08/05/21, 13:09

  10. Oli Bartsch voted on patch set 5 V +1 CR +1 08/05/21, 13:09

  11. core-ci voted on patch set 4 V -1 08/05/21, 13:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14139

  12. core-ci voted on patch set 5 V +1 08/05/21, 13:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14140

  13. Jochen Roth voted on patch set 5 V +1 CR +1 08/05/21, 15:35

  14. Benni Mack voted on patch set 5 V +2 CR +2 08/05/21, 18:52

  15. Benni Mack merged patch set 6 08/05/21, 18:52