Review main Merged

70208[TASK] Quote database identifier in TCA

Jochen Roth CR +2 V +2 Normal +47 −47 updated 10/19/21, 13:20

Commit message

Add quoting for 'foreign_table_where'
in TCA.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 38

Show 18 more files

Review log 2640

Show 815 earlier messages
  1. Jochen Roth uploaded patch set 1 08/05/21, 08:36

  2. Jochen Roth uploaded patch set 2 08/05/21, 08:41

  3. Oliver Klee updated the commit message in patch set 3 08/05/21, 08:41

  4. Jochen Roth updated the commit message in patch set 4 08/05/21, 08:42

  5. core-ci voted on patch set 1 V -1 08/05/21, 08:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14126

  6. core-ci voted on patch set 3 V -1 08/05/21, 08:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14128

  7. core-ci voted on patch set 4 V -1 08/05/21, 09:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14129

  8. core-ci voted on patch set 2 V -1 08/05/21, 09:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14127

  9. Jochen Roth uploaded patch set 5 08/05/21, 11:33

  10. core-ci voted on patch set 5 V -1 08/05/21, 11:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14134

  11. Jochen Roth uploaded patch set 6 08/05/21, 12:07

  12. core-ci voted on patch set 6 V -1 08/05/21, 12:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14136

  13. Jochen Roth uploaded patch set 7 08/05/21, 12:38

  14. core-ci voted on patch set 7 V +1 08/05/21, 12:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14137

  15. Jochen Roth updated the commit message in patch set 8 08/05/21, 13:13

  1. core-ci voted on patch set 8 V +1 08/05/21, 13:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14141

  2. Christian Kuhn commented on patch set 8 08/05/21, 22:49

    site.php:32

    it's kinda weird there's an order by statement in there. smells fishy.

    JsonRenderer.typoscript:113

    shouldn't this rather be in the other patch?
  3. Jochen Roth uploaded patch set 9 08/09/21, 08:58

  4. core-ci voted on patch set 9 V +1 08/09/21, 09:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14310

  5. Jochen Roth uploaded patch set 10 08/10/21, 10:45

  6. core-ci voted on patch set 10 V +1 08/10/21, 10:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14469

  7. Jochen Roth commented on patch set 10 08/10/21, 11:08

    site.php:32 Reply

    Tested and seems like its working without "ORDER BY"

    JsonRenderer.typoscript:113 Reply

    Done
  8. Jochen Roth uploaded patch set 11 09/03/21, 19:00

  9. core-ci voted on patch set 11 V +1 09/03/21, 19:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16213

  10. Georg Ringer voted on patch set 11 V +1 CR +1 09/06/21, 06:53

  11. Jochen Roth uploaded patch set 12 10/07/21, 13:45

  12. Jochen Roth uploaded patch set 13 10/07/21, 13:58

  13. core-ci voted on patch set 12 V +1 10/07/21, 14:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17746

  14. core-ci voted on patch set 13 V +1 10/07/21, 14:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17750

  15. Georg Ringer voted on patch set 13 V +1 CR +1 10/13/21, 04:22

  16. Simon Schaufelberger voted on patch set 13 CR +1 10/15/21, 23:14

  17. Simon Schaufelberger commented on patch set 13 10/15/21, 23:20

  18. Christian Kuhn rebased onto patch set 14 10/19/21, 12:53

  19. Christian Kuhn commented on patch set 14 10/19/21, 12:53

    just rebased for now.
  20. Christian Kuhn commented on patch set 14 10/19/21, 13:03

    site.php:32 Reply

    Done. Actually, that's ok.
  21. Christian Kuhn voted on patch set 14 V +1 CR +1 10/19/21, 13:03

  22. Simon Schaufelberger voted on patch set 14 V +1 CR +1 10/19/21, 13:07

  23. core-ci voted on patch set 14 V +1 10/19/21, 13:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18311

  24. Christian Kuhn voted on patch set 14 V +2 CR +2 10/19/21, 13:20

  25. Christian Kuhn merged patch set 15 10/19/21, 13:20