Review main Merged

70209[BUGFIX] Use correct fallback for default page TSconfig

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 08/05/21, 13:43

Commit message

The value of a TSconfig entry in the $TSdata array, forwarded
to the ModifyLoadedPageTsConfigEvent, has to be a string.

Therefore the fallback must be a string, too. Otherwise it would
make it unnecessary hard for extension authors to extend the
default TSconfig using the mentioned event as they have to
check for the actual type first.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Achim Fritz +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 08/05/21, 10:42

  2. core-ci voted on patch set 1 V +1 08/05/21, 10:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14132

  3. Achim Fritz voted on patch set 1 CR +1 08/05/21, 11:26

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 08/05/21, 11:33

  5. Benni Mack voted on patch set 1 V +1 CR +1 08/05/21, 13:38

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 08/05/21, 13:43

  7. Oli Bartsch merged patch set 2 08/05/21, 13:43