Review main Merged

70210[TASK] Declare core as replacement for t3g/svg-sanitizer

Oliver Hader CR +2 V +2 Easy +5 −3 updated 08/10/21, 06:44

Commit message

Functionality of package t3g/svg-sanitizer has been
integrated into the TYPO3 core.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Oliver Hader uploaded patch set 1 08/05/21, 12:45

  2. core-ci voted on patch set 1 V +1 08/05/21, 12:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14138

  3. Andreas Kienast voted on patch set 1 CR +1 08/05/21, 12:59

  4. Simon Gilli commented on patch set 1 V +1 CR +1 08/05/21, 13:58

    Hard to test but finally found a way with a local path repo 😊
  5. Oli Bartsch voted on patch set 1 V +1 CR +1 08/05/21, 14:28

  6. Christian Kuhn voted on patch set 1 CR +1 08/05/21, 15:22

  7. Oliver Hader uploaded patch set 2 08/10/21, 05:21

  8. core-ci voted on patch set 2 V +1 08/10/21, 05:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14424

  9. Oliver Hader commented on patch set 2 V +2 CR +2 08/10/21, 06:20

    Okay, now also tested it in v10.4 as well... using this patch * `t3g/svg-sanitizer` does not issue conflicts concerning locked state of the underlying SVG lib * `typo3conf/ext/svg_sanitizer` is not exposed anymore as extension
  10. Oliver Hader merged patch set 3 08/10/21, 06:44