Review main Merged

70233[TASK] Set explicitADmode to explicitAllow in DefaultConfiguration

Christian Kuhn CR +2 V +2 Normal +100 −2 updated 08/05/21, 20:22

Commit message

LocalConfiguration BE/explicitADmode controls wether
field permissions for backend user groups are additive
(explicitAllow) or subtractive (explicitDeny).

By means of best practice in the IT world, user permissions
should always be configured additive - which is called the
"Principle of Least Privilege" (see https://en.wikipedia.org/wiki/Principle_of_least_privilege).

TYPO3's permission system already uses PoLP in all cases
of backend groups except for the permission system of
"Allowed Content Types"

This is not only important from a security point of view
in terms of permissions (for instance when an extension adds new
CTypes), it's also possible to easily create a hard to
understand mess in explicitDeny mode with nested groups.

The default / fallback in DefaultConfiguration however
has always been explicitDeny since "ever". New instances
always got explicitAllow due to it being set in
FactoryConfiguration - since TYPO3 v6.2.

We can expect the vast majority of instances to run
with explicitAllow already, either since the instance
is younger than ~7 years, or because an admin already
did set the default to explicitAllow for any instance
that works with a non-trivial backend user group setup.

This change turns the default in DefaultConfiguration
around towards explicitAllow. A simple silent upgrade
within install tool sets the value to explicitDeny
in LocalConfiguration for instances that still use this,
so this change is fully transparent and b/w compatible.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 812

  1. Christian Kuhn uploaded patch set 1 08/05/21, 18:32

  2. core-ci voted on patch set 1 V -1 08/05/21, 18:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14160

  3. Christian Kuhn uploaded patch set 2 08/05/21, 18:47

  4. core-ci voted on patch set 2 V +1 08/05/21, 19:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14161

  5. Benni Mack updated the commit message in patch set 3 08/05/21, 19:36

  6. Benni Mack voted on patch set 3 V +1 CR +1 08/05/21, 19:37

  7. Wouter Wolters voted on patch set 3 V +1 CR +1 08/05/21, 19:47

  8. core-ci voted on patch set 3 V -1 08/05/21, 19:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14164

  9. core-ci voted on patch set 3 V +1 08/05/21, 20:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14164

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 08/05/21, 20:21

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 08/05/21, 20:22

  12. Christian Kuhn merged patch set 4 08/05/21, 20:22