Review main Merged

70236[TASK] Deprecate GeneralUtility::minifyJavaScript()

Benni Mack CR +2 V +2 Normal +80 −29 updated 09/17/21, 10:08

Commit message

The method "GeneralUtility::minifyJavaScript()"
was introduced back in 2007 when TYPO3 used
"jsmin". Then, the hook was introduced, and
"jsmin" was removed from TYPO3 Core again.

TYPO3 Core also added - in parallel - the concept
of the PageRenderer, which also contains a hook for
extensions (such as EXT:min), or then calls the
ResourceCompressor, which takes care of compressing
and concatenating resources.

The hook is now moved from GeneralUtility and executed
within the ResourceCompressor, so extensions
can still use the hook to compress inline JavaScript.

However, the method is completely mis-placed nowadays
and is moved to the according place in ResourceCompressor.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1320

  1. Benni Mack uploaded patch set 1 08/05/21, 19:53

  2. core-ci voted on patch set 1 V +1 08/05/21, 20:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14169

  3. Benni Mack updated the commit message in patch set 2 08/10/21, 17:16

  4. core-ci voted on patch set 2 V +1 08/10/21, 17:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14503

  5. Benni Mack uploaded patch set 3 09/16/21, 10:52

  6. core-ci voted on patch set 3 V +1 09/16/21, 11:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16792

  7. Benni Mack uploaded patch set 4 09/16/21, 13:04

  8. core-ci voted on patch set 4 V +1 09/16/21, 13:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16800

  9. Benni Mack commented on patch set 5 09/16/21, 13:23

    Published edit on patch set 4.
  10. Benni Mack commented on patch set 6 09/16/21, 13:24

    Published edit on patch set 5.
  11. core-ci voted on patch set 5 V +1 09/16/21, 13:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16802

  12. core-ci voted on patch set 6 V +1 09/16/21, 13:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16803

  13. Oli Bartsch uploaded patch set 7 09/16/21, 14:34

  14. Oli Bartsch voted on patch set 7 V +1 CR +1 09/16/21, 14:34

  15. core-ci voted on patch set 7 V +1 09/16/21, 14:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16805

  16. Wouter Wolters commented on patch set 7 CR +1 09/17/21, 08:37

    GeneralUtilityTest.php:2319

    shouldn't this method be moved to UnitDeprecated folder?
  17. Benni Mack commented on patch set 7 09/17/21, 08:38

    GeneralUtilityTest.php:2319 Reply

    Thought so too, but it has of no use anymore (unlike in 4.x times) as it just checks if a hook is executed.
  18. Oliver Hader voted on patch set 7 V +1 CR +1 09/17/21, 09:59

  19. Benni Mack voted on patch set 7 V +2 CR +2 09/17/21, 10:08

  20. Benni Mack merged patch set 8 09/17/21, 10:08