70236[TASK] Deprecate GeneralUtility::minifyJavaScript()
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Wouter Wolters +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Page/PageRenderer.php+3 −16
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+19 −0
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+2 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94791-GeneralUtilityminifyJavaScript.rstnew+49 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php2+0 −13
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1320
-
Benni Mack uploaded patch set 1 08/05/21, 19:53
-
core-ci voted on patch set 1 V +1 08/05/21, 20:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14169
-
Benni Mack updated the commit message in patch set 2 08/10/21, 17:16
-
core-ci voted on patch set 2 V +1 08/10/21, 17:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14503
-
Benni Mack uploaded patch set 3 09/16/21, 10:52
-
core-ci voted on patch set 3 V +1 09/16/21, 11:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16792
-
Benni Mack uploaded patch set 4 09/16/21, 13:04
-
core-ci voted on patch set 4 V +1 09/16/21, 13:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16800
-
Benni Mack commented on patch set 5 09/16/21, 13:23
Published edit on patch set 4. -
Benni Mack commented on patch set 6 09/16/21, 13:24
Published edit on patch set 5. -
core-ci voted on patch set 5 V +1 09/16/21, 13:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16802
-
core-ci voted on patch set 6 V +1 09/16/21, 13:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16803
-
Oli Bartsch uploaded patch set 7 09/16/21, 14:34
-
Oli Bartsch voted on patch set 7 V +1 CR +1 09/16/21, 14:34
-
core-ci voted on patch set 7 V +1 09/16/21, 14:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16805
-
Wouter Wolters commented on patch set 7 CR +1 09/17/21, 08:37
GeneralUtilityTest.php:2319shouldn't this method be moved to UnitDeprecated folder? -
Benni Mack commented on patch set 7 09/17/21, 08:38
GeneralUtilityTest.php:2319ReplyThought so too, but it has of no use anymore (unlike in 4.x times) as it just checks if a hook is executed. -
Oliver Hader voted on patch set 7 V +1 CR +1 09/17/21, 09:59
-
Benni Mack voted on patch set 7 V +2 CR +2 09/17/21, 10:08
-
Benni Mack merged patch set 8 09/17/21, 10:08