Review main Abandoned

70237[WIP][TASK] Send events for updating the pagetree instead of inlineJS

Benni Mack CR 0 V 0 Normal +75 −57 updated 08/06/21, 11:18

Commit message

This change removes some inline JavaScript within
Page Module and List Module and centralizes "window.fsMod"
in the outer frame.

setHighlight() is not needed, as the next request
sets the tree state anyways.

Review

  • Code review CR 0
  • Verified V 0

Files 9

Review log 47

  1. Benni Mack uploaded patch set 1 08/05/21, 20:12

  2. Benni Mack uploaded patch set 2 08/05/21, 20:15

  3. core-ci voted on patch set 1 V -1 08/05/21, 20:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14171

  4. core-ci voted on patch set 2 V -1 08/05/21, 20:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14172

  5. Benni Mack uploaded patch set 3 08/06/21, 07:30

  6. core-ci voted on patch set 3 V +1 08/06/21, 07:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14186

  7. Benni Mack abandoned the change 08/06/21, 11:18

    won't do this