Review main Merged

70239[TASK] Merge phpunit setup files to Build/phpunit

Christian Kuhn CR +2 V +2 Hard +265 −25 updated 08/06/21, 13:34

Commit message

typo3/testing-framework ships default .xml and
bootstrap files for phpunit unit and functional tests.

They are however quite hard to maintain since the
testing-framework supports multiple core versions at
once, but core occassionally needs version specific
settings.

The patch copies the files from the testing-framework
to Build/phpunit and adapts core usages.

The files within testing-framework will be kept, but
will receive an additional "these are boilerplates,
consider copying them to your extension" hint for
extension developers.

The local .xml files are now:
* Compatible with phpunit 9
* Let tests fail if phpunit marks a test with warning.
  With this enabled, we would have seen the issues
  fixed with #94724 and #94723 with initial #94706
  already. Good to do that now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 10

Review log 1014

  1. Christian Kuhn uploaded patch set 1 08/05/21, 22:36

  2. Christian Kuhn rebased onto patch set 2 08/05/21, 22:37

  3. core-ci voted on patch set 2 V -1 08/05/21, 22:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14177

  4. core-ci voted on patch set 1 V -1 08/05/21, 22:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14176

  5. Christian Kuhn uploaded patch set 3 08/05/21, 22:58

  6. core-ci voted on patch set 3 V +1 08/05/21, 23:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14178

  7. Wouter Wolters commented on patch set 3 CR -1 08/06/21, 09:04

    FunctionalTests.xml:28

    indentation is not all the same in this file
  8. Christian Kuhn uploaded patch set 4 08/06/21, 10:42

  9. Christian Kuhn commented on patch set 4 08/06/21, 10:42

    FunctionalTests.xml:28 Reply

    thx. missed that one ...
  10. core-ci voted on patch set 4 V +1 08/06/21, 10:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14192

  11. Benni Mack voted on patch set 4 V +1 CR +1 08/06/21, 11:17

  12. Oli Bartsch voted on patch set 4 V +1 CR +1 08/06/21, 13:31

  13. Christian Kuhn voted on patch set 4 V +2 CR +2 08/06/21, 13:33

  14. Christian Kuhn merged patch set 5 08/06/21, 13:34