Review main Merged

70241[TASK] Skip database creation in some functional tests

Christian Kuhn CR +2 V +2 Hard +370 −57 updated 08/06/21, 18:28

Commit message

Some functional tests don't need a fully set up database
with all tables and fields to test the subject.

Those now leverage a new testing-framework
feature to skip database creation.

Good examples are the core redis and memcache cache
backend tests as well as a lot of fluid view helper
functional tests.

The speed improvement of around factor ten is
significant enough to use it if possible.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 69

Show 49 more files

Review log 914

  1. Christian Kuhn uploaded patch set 1 08/06/21, 00:56

  2. core-ci voted on patch set 1 V +1 08/06/21, 01:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14180

  3. Christian Kuhn uploaded patch set 2 08/06/21, 15:40

  4. core-ci voted on patch set 2 V +1 08/06/21, 15:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14214

  5. core-ci voted on patch set 2 V -1 08/06/21, 16:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14216

  6. core-ci voted on patch set 2 V +1 08/06/21, 17:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14216

  7. Jochen Roth voted on patch set 2 V +1 CR +1 08/06/21, 18:09

  8. Wouter Wolters commented on patch set 2 V +1 CR +1 08/06/21, 18:09

    Verified by tests
  9. Christian Kuhn updated the commit message in patch set 3 08/06/21, 18:15

  10. Wouter Wolters voted on patch set 3 V +1 CR +1 08/06/21, 18:17

  11. Jochen Roth voted on patch set 3 V +1 CR +1 08/06/21, 18:20

  12. core-ci voted on patch set 3 V +1 08/06/21, 18:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14220

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 08/06/21, 18:28

  14. Christian Kuhn merged patch set 4 08/06/21, 18:28